Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaky scroll bar #12868

Open
marcellamaki opened this issue Nov 20, 2024 — with Slack · 6 comments
Open

Shaky scroll bar #12868

marcellamaki opened this issue Nov 20, 2024 — with Slack · 6 comments
Labels
DEV: frontend P1 - important Priority: High impact on UX TODO: needs decisions Design or specifications are necessary

Comments

Copy link
Member

With this <https://kolibri-catalog-ar.learningequality.org/ar/learn/#/topics/t/a7b5ff611bcc5883b3b435ef08c6f521/folders?prevName=LIBRARY|specific topic>, with this specific browser height (1978.75 is the height of the page body), when I scroll down it goes into this wild up-down jiggle. Stops when I scroll back up.

Slack Message

@marcellamaki marcellamaki added DEV: frontend P1 - important Priority: High impact on UX labels Nov 20, 2024 — with Slack
@marcellamaki marcellamaki added this to the Kolibri 0.18: General maintenance milestone Nov 20, 2024 — with Slack
@MisRob
Copy link
Member

MisRob commented Nov 20, 2024

@marcellamaki I think it could be the same issue as #10663 :)

Would expect some complexity. However, I had an idea of getting rid of JavaScript based solution completely in favor or using simply the position: sticky so maybe this would be a time to experiment. It's aligned with other areas where we benefited from removing custom JavaScript tweaks. Best to check the browser compatibility more thoroughly, I don't think I did it when I wrote the comment.

@MisRob MisRob added the TODO: needs decisions Design or specifications are necessary label Nov 25, 2024
@FilledEther20
Copy link

Hi Everyone,
If this issue is currently unassigned, I’d love the opportunity to work on it. Could you please assign it to me?
Thanks!

@marcellamaki
Copy link
Member Author

Hi @FilledEther20 - thank you for your interest in contributing to Kolibri! This issue is not quite ready for contribution as you can see that it still has the "needs decision" tag applied. However, we will continue to open and tag issues for community contribution now that we have returned from our 2 week end of year office closure, and there will be more opportunities for your contributions in the coming weeks. Happy new year!

@FilledEther20
Copy link

Sure, no worries. I just wanted to confirm, as a rule of thumb for future searches to contribute to this project, are tags explicitly limited to 'help wanted' and 'good first issues,' or is there no such restriction?
Thanks, and Happy New Year!

@MisRob
Copy link
Member

MisRob commented Jan 22, 2025

Hi @FilledEther20, it's best to find unassigned 'help wanted', thank you!

@MisRob
Copy link
Member

MisRob commented Jan 22, 2025

We agreed (Slack thread) we'd like to move towards position:sticky, however the time of this update is not yet decided

the next step is to get the latest browser stats from our ping back data to see if we can get some more sensible minimum values for our browserslist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P1 - important Priority: High impact on UX TODO: needs decisions Design or specifications are necessary
Projects
None yet
Development

No branches or pull requests

3 participants