Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 'Bookmarks' card (i.e. to click into the bookmarks selection) uses the new folder card or KCard #12694

Open
marcellamaki opened this issue Oct 2, 2024 · 4 comments

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Oct 2, 2024

The "Bookmarks" card that appears at the top of the channel list should be updated to use a KCard. Even though it is a simple item, and not a contentNode itself, the accessibility and layout standardization that comes with KCard are useful.

@marcellamaki marcellamaki self-assigned this Oct 2, 2024
@marcellamaki marcellamaki changed the title Update the 'Bookmarks' card (i.e. to click into the bookmarks selection) uses the new folder card or `KCard Update the 'Bookmarks' card (i.e. to click into the bookmarks selection) uses the new folder card or KCard Oct 2, 2024
@marcellamaki marcellamaki removed their assignment Oct 2, 2024
@MisRob
Copy link
Member

MisRob commented Oct 3, 2024

Note that KCard, even if a single item, still need to be wrapped within KCardGrid

@Abhishek-Punhani
Copy link
Contributor

@marcellamaki @MisRob Can i work on this issue?

@marcellamaki
Copy link
Member Author

Hi @Abhishek-Punhani - thank you for your interest in contributing to Kolibri! This issue is not open for community contribution.

We will continue to open and tag issues for community contribution now that we have returned from our 2 week end of year office closure, and there will be more opportunities for your contributions in the coming weeks. Happy new year!

@Abhishek-Punhani
Copy link
Contributor

@marcellamaki Thank you for the update! I’ll keep an eye on upcoming issues and look forward to contributing. Happy New Year to you and the team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants