Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UserTable tests pass #12664

Open
nucleogenesis opened this issue Sep 16, 2024 · 2 comments
Open

Make UserTable tests pass #12664

nucleogenesis opened this issue Sep 16, 2024 · 2 comments
Assignees
Labels
help wanted Open source contributors welcome TAG: regression Something that previously worked TAG: unit tests Add or update tests

Comments

@nucleogenesis
Copy link
Member

Observed behavior

See #12662 - you will need to change the tests which are ignored there using the xit() function to use it and test the same cases.

I did not find it easy to work out how to fix the tests without rewriting them. The way I understand it, the behavior being tested is actually behavior that is defined in a parent component.

That is to say, UserTable is setup to accommodate the v-model - so it's own this.value prop indicates what ids are selected. Then, when a checkbox is clicked, we emit the input event with a payload of what this.value should be after the checkbox was clicked.

The parent then will update whichever of its own local values it is passing to the UserTable v-model and can use it elsewhere.

These tests directly mount UserTable - so I think that the issue is to do with the fact that there is no parent component mounted w/ UserTable that is reacting to the v-model relationship. So, in these tests, UserTable is emitting events into the aether.

Expected behavior

Tests in UserTable spec should not be ignored.

User-facing consequences

n/a

Context

develop

@nucleogenesis nucleogenesis added TAG: unit tests Add or update tests TAG: regression Something that previously worked help wanted Open source contributors welcome labels Sep 16, 2024
@Suchitra-Sahoo
Copy link

Suchitra-Sahoo commented Jan 9, 2025

@nucleogenesis I would like to work in it. Kindly assign this issue to me.

@AlexVelezLl
Copy link
Member

Hey @Suchitra-Sahoo! Thanks for your interest in contributing to this issue. I will assign this to you. If you have any question, please let us know! 👐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open source contributors welcome TAG: regression Something that previously worked TAG: unit tests Add or update tests
Projects
None yet
Development

No branches or pull requests

4 participants