Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android LOD - Library - The tooltip 'Remove pin from my library page' remains visible #11441

Open
pcenov opened this issue Oct 20, 2023 · 12 comments
Assignees
Labels
DEV: frontend help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@pcenov
Copy link
Member

pcenov commented Oct 20, 2023

Observed behavior

After pinning/unpinning a library the tootltip remains visible on the page unless I tap somewhere. If I scroll up the tooltip overlaps the top navigation bar and looks weird.

Expected behavior

The pin should either not be displayed at all or disappear.

Steps to reproduce the issue

  1. Install the latest APK build from Fix up reactivity and display issues for remote libraries on LibraryPage and ExploreLibrariesPage #11419 and setup a learn-only device on an Android device.
  2. Go to the Library page and pin/unpin a library.

More information

2023-10-20_17-39-45

Usage Details

Kolibri 0.16beta6
Android app

@pcenov
Copy link
Member Author

pcenov commented Oct 20, 2023

@radinamatic

@marcellamaki marcellamaki added P2 - normal Priority: Nice to have help wanted Open source contributors welcome DEV: frontend labels Oct 27, 2023
@marcellamaki
Copy link
Member

The first task might be to see if this behavior is replicable in other places where a tooltip is used. If it appears only in this situation, and not in other places where the component is used, we can fix within the context of this bug. If it appears in other places, however, the issue may require making changes in the <KTooltip> component, which is part of the Kolibri Design System, rather than actually making changes in the Kolibri Library page.

@nick2432
Copy link
Contributor

can i work on this?

@bjester
Copy link
Member

bjester commented Jan 22, 2024

Hi @nick2432, I just assigned you to a different issue. I see you're now assigned 3 issues, so when those others are completed and fixes merged, please comment again on this issue and we can assign you. Thank you for your interest in contributing

@nick2432
Copy link
Contributor

@bjester , yes, I noticed I have two assigned issues. Thank you for your attention, and I apologize for any inconvenience caused.

@AlexanderBlanchardAC
Copy link

Hi,
If this issue is still unresolved, may I be assigned it?
Cheers,
Alex

@MisRob
Copy link
Member

MisRob commented Apr 1, 2024

@AlexanderBlanchardAC Hi Alex, yes, thank you for volunteering

@rtibbles
Copy link
Member

rtibbles commented Nov 8, 2024

Unassigning as it has been over 6 months with no activity.

@josephinoo
Copy link

Can I get this issue assigned? 🙂

@AlexVelezLl
Copy link
Member

Thanks for your interest in contributing to this issue @josephinoo! I will assign this to you :)

@yashhash2
Copy link
Contributor

Hi @AlexVelezLl If @josephinoo isn't working on this issue I would love to be assigned ; )

@josephinoo
Copy link

Hi @yashhash2, yes I am working on this issue, I will upload my changes soon. Happy new year 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

10 participants