Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual testing]: Add visual tests for KIconButton #927

Open
AlexVelezLl opened this issue Feb 4, 2025 · 3 comments
Open

[Visual testing]: Add visual tests for KIconButton #927

AlexVelezLl opened this issue Feb 4, 2025 · 3 comments
Assignees
Labels
Component: KIconButton help wanted Open source contributors welcome type: task Something that needs to be done Visual testing

Comments

@AlexVelezLl
Copy link
Member

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Context

We recently introduced a new visual testing system in KDS to prevent visual regressions and ensure UI consistency, and we want to start populating our KDS components with visual tests.

If you are not familiar yet with our visual testing system. Please refer to our Visual Testing Guide. You can also check the existing tests for KButton as an example.

Additionally, see the KIconButton documentation for reference.

Desired behavior

KIconButton should have visual tests to cover at least these snapshots:

  • KIconButton with raised-button appearance.
  • KIconButton with flat-button appearance.
  • KIconButton with raised-button appearance disabled.
  • KIconButton with flat-button appearance disabled.
  • KIconButton with size = 'mini'.
  • KIconButton with size = 'small'.
  • KIconButton with size = 'regular'.
  • KIconButton with size = 'large'.
  • KIconButton with Dropdown menu.

Acceptance criteria

  • A new visual test suite is created for KIconButton.
  • The test includes all required snapshots.
  • The test runs successfully and captures the expected snapshots.
@AlexVelezLl AlexVelezLl added Component: KIconButton help wanted Open source contributors welcome type: task Something that needs to be done Visual testing labels Feb 4, 2025
@adibmbrk
Copy link

adibmbrk commented Feb 5, 2025

Hi @AlexVelezLl, can i work on this issue please?

@GautamBytes
Copy link

Hello @AlexVelezLl , I would like to contribute to this issue , would be grateful if can assign this to me. Looking forward to contribute!

@AlexVelezLl
Copy link
Member Author

Thank you @adibmbrk and @GautamBytes for your interest in contributin to Learning Equality! I will assign this to @adibmbrk since he asked for it first, but stay tunned @GautamBytes that we will continue opening more issues :).

@adibmbrk if you have any questions, please let us know 👐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: KIconButton help wanted Open source contributors welcome type: task Something that needs to be done Visual testing
Projects
None yet
Development

No branches or pull requests

3 participants