-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KTable]: Add margin to empty text #881
Comments
Hey @AlexVelezLl, I want to work on this issue. |
Hey @karankoder! For sure, will assign this to you :) |
Hi @AlexVelezLl , Thank you for assigning this issue to me! I wanted to let you know that I’m currently observing the correct margin behavior on empty data. Could you kindly provide the steps to reproduce this behavior? |
Hi @AlexVelezLl, I hope you're doing well! I just wanted to follow up regarding the steps to reproduce the margin behavior issue with the empty table. Additionally, could I work on #883 as well? Both issues are related to the KTable component, so I can fix them together in a single PR if you agree. |
Hey @karankoder. Apologiesfor the late response. Before assigning you that issue lets try the KDS dev process with this issue first! When we need to replicate something like this, we can use the KDS Playground, and anything we modify there, we can see it in http://localhost:4000/playground. If we place some components there, and a So we can try replicating it effectively and once there is a PR for this issue we can assign you the next one! |
Product
Kolibri.
Current behavior
When we have an empty table, we dont have the any margins when showing the empty text as the margins when we show the table when we have data.
E.g.
Look at the margin between the hader and the previous element when we have data:
But if we have an empty table, the empty text is shown without any margin.
Desired behaviour
The empty message should have
margin-top: 16px
andmargin-bottom: 16px
just as the margins we have when the table has data.The text was updated successfully, but these errors were encountered: