Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace core burst-loading code with calls to bas-apres #61

Closed
jkingslake opened this issue Oct 28, 2024 · 2 comments
Closed

replace core burst-loading code with calls to bas-apres #61

jkingslake opened this issue Oct 28, 2024 · 2 comments

Comments

@jkingslake
Copy link
Member

An improvement would be to replace the code used at the core of from_dats to load bursts from dat files with calls to a properly designed package which does this, bas-apres.

A good place to start would be here https://github.com/antarctica/bas-apres/blob/master/apres/read_apres.py

It would be a major rewrite and involve several methods in from_dats.

I would involve something like this

 with ApRESFile(args.infile) as f:
        for burst in f.read():
            header = burst.header
            data = burst.data

In place of any code where we extract bursts in the current version, e.g., _burst_to_3d_arrays. But it will require changes in many other places too.

@jkingslake
Copy link
Member Author

#67 does this

@jkingslake
Copy link
Member Author

now that #67 is merged this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant