Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment fails to migrate because of ratelimiting and too much async #16

Open
sgandon opened this issue Jan 12, 2024 · 2 comments
Open

Comments

@sgandon
Copy link
Contributor

sgandon commented Jan 12, 2024

The migrate script is making a lot of async calls (here and here). This means that all segment creation calls are almost launched at the same time.
The rate limit if quickly reached and many calls wait for the ratelimit reset time together. And try again to call the endpoint altogether and eventually fails because of Too Many Requests.

@cgreenld
Copy link
Contributor

cgreenld commented Feb 5, 2024

Hey @sgandon appreciate your thoughts here - LaunchDarkly does not adjust the rate limits on our application site, so we are required to manage those async calls vs getting a limit moved. I understand this adds to the time needed to migrate with this script.

Open to suggestions on an optimization on the flow to possible avoid this, but there is a not a way to raise the limits

@sgandon
Copy link
Contributor Author

sgandon commented Feb 5, 2024

I will suggest a PR to retry indefinitely and not break after the second retry. This eventually get things done.

cgreenld added a commit that referenced this issue Mar 1, 2024
fix(#16): by recursing to try to patch things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants