Tagging issues 777 and 778 #1607
Conversation
|
@FrankMittelbach @davidcarlisle I have now changed the taggging of presentation tables to use "normal" tags and an ARIA attribute. This works better with derivation. OK? |
|
Looks good to me |
| \AddToHook{cmd/frontmatter/before}{\par\@@_sec_end:n{-10}} | ||
| \AddToHook{cmd/mainmatter/before} {\par\@@_sec_end:n{-10}} | ||
| \AddToHook{cmd/backmatter/before} {\par\@@_sec_end:n{-10}} | ||
| \AddToHook{cmd/appendix/before} {\par\@@_sec_end:n{-10}} |
There was a problem hiding this comment.
Probably better would be to move the \par command into those comands eventually (to ensure that they always behave identically (with or without tagging).
Also (not checked) but isn't \@@_sec_end:n{-10} a related command and should be in a socket rather than a hook?
Doesn't have to be done now, but there should be a TODO if this is something we should cleanup at some point.
There was a problem hiding this comment.
I'm not sure if a \par inside \@@_sec_end:n is always wanted that's why I added if here explicitly (In the other cases the command is currently is used inside the sectioning commands in vmode, so a \par inside the command is not needed).
I'm not sure what you mean by sockets. \mainmatter etc are defined by the classes, so we can not simply redefine them to add a socket but have to use a generic hook. The problem was that the hook is before the \clearpage and so not necessarly in vmode.
| \__tag_tbl_enable: | ||
| \AssignSocketPlug{tagsupport/tbl/hmode/begin}{LayoutTable} | ||
| \AssignSocketPlug{tagsupport/tbl/vmode/begin}{LayoutTable} | ||
| \clist_clear:N \l_@@_header_rows_clist | ||
| \clist_clear:N \l_@@_header_columns_clist |
There was a problem hiding this comment.
If I go from presentation back to table/tagging=on it should probably reset the plugs or not? If so the plugs have to be set also above, as this this might happen on the same group level.
If my assumption is correct, then this also needs a test case.
There was a problem hiding this comment.
\__tag_tbl_enable: sets all sockets, including the begin sockets to the defaults. So the presentation mode only has to overwrite the two.
There was a problem hiding this comment.
and there is a testfile (table-015-presentation in testfiles-table-luatex) which tests the switch from presentation back to normal tagging in one group.
|
@FrankMittelbach, @davidcarlisle I now added both options, (aria-role and div) so I think that is good to merge? |
| % (p/m/b). In such cases the second option works better: it keeps the tagging code active, | ||
| % but adds an ARIA-role as attribute. When deriving to html this gives the best result | ||
| % as it keeps the layout. | ||
| % The last option changes the tag names and creates a number of DIV structures. |
There was a problem hiding this comment.
o ... creates simply a number of ...
| @@ -228,7 +234,7 @@ | |||
| % \item Not every table should be tagged as a Table structure, often they are | |||
| % only used as layout help, e.g. to align authors in a title pages. In such uses | |||
| % the tagging of the table must be deactivated with \verb|\tagpdfsetup{table/tagging=false}| | |||
| % or \verb|\tagpdfsetup{table/tagging=presentation}|. | |||
| % or changed with \verb|\tagpdfsetup{table/tagging=presentation}|. | |||
There was a problem hiding this comment.
... to become a presentation table.
what about the DIV version?
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated