Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#49 | MediaWiki 1.43: Deprecated usage of SkinModule #49

Closed
AlPha5130 opened this issue Dec 22, 2024 · 5 comments · Fixed by #52
Closed

#49 | MediaWiki 1.43: Deprecated usage of SkinModule #49

AlPha5130 opened this issue Dec 22, 2024 · 5 comments · Fixed by #52
Assignees

Comments

@AlPha5130
Copy link
Collaborator

This page is using the deprecated ResourceLoader module "skins.lakeus.styles".
[1.43] The use of the i18n-all-lists-margins feature with SkinModule is deprecated as it is now provided by elements. Please remove and add elements, drop support for RTL languages, or incorporate the styles provided by this module into your skin.
[1.43] The use of the interface-message-box feature with SkinModule is deprecated in favor of CodexModule. Please remove this feature.
More information can be found at [[mw:Manual:ResourceLoaderSkinModule]].

@winstonsung winstonsung changed the title Deprecated usage of SkinModule #49 | Deprecated usage of SkinModule Dec 22, 2024
@lakejason0
Copy link
Owner

Other problems after 1.43: the --color-base and the like CSS variables seems to be conflict with certain OOUI styles.

@lakejason0
Copy link
Owner

lakejason0 commented Dec 23, 2024

Regarding Interface message box: this needs further cleanup in the main LESS file.

@winstonsung winstonsung changed the title #49 | Deprecated usage of SkinModule #49 | MediaWiki 1.43: Deprecated usage of SkinModule Jan 16, 2025
@winstonsung
Copy link
Collaborator

Updated the branching strategy to handle the situation in [[mw:Manual:ResourceLoaderSkinModule]]:

@winstonsung winstonsung self-assigned this Jan 16, 2025
winstonsung added a commit that referenced this issue Jan 16, 2025
Drop support for MediaWiki 1.39.x, 1.41.x, 1.42.x in master branch.
Namespaced MediaWiki\SiteStats\SiteStats.
Remove the ResourceLoader targets system.

Bug: #49
Bug: #50
Bug: #51
Change-Id: Ia3b26ab9cf1e0f487024a7a97cf102a49b06c180
@winstonsung winstonsung linked a pull request Jan 16, 2025 that will close this issue
@winstonsung
Copy link
Collaborator

Regarding Interface message box: this needs further cleanup in the main LESS file.

MediaWiki core Skin.php:

// Since 1.41, styling for mw-message-box is only required for
// messages that appear in article content.
// This should only be removed when a suitable alternative exists
// e.g. https://phabricator.wikimedia.org/T363607 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants