Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pierce_set calculation is returning different results comparing to CBE comfort tools #478

Open
BingWangUS opened this issue Dec 9, 2019 · 0 comments
Open

pierce_set calculation is returning different results comparing to CBE comfort tools #478

BingWangUS opened this issue Dec 9, 2019 · 0 comments
Assignees
@chriswmackey
Labels
ladybug legacy triage

Comments

@BingWangUS
Copy link

The SET calculation is giving different results comparing to CBE comfort tools.

image

An investigation of the source code from Ladybug tools and CBE comfort tools indicated that the difference is caused by the while loop (line 300) in Ladybug tools and the do while loop used in CBE comfort tool.
@mostaphaRoudsari mostaphaRoudsari transferred this issue from ladybug-tools/ladybug-comfort Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriswmackey chriswmackey

Labels
ladybug legacy triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chriswmackey @BingWangUS