-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the Title and Legend Outputs for All Graphic Components #131
Comments
|
The thing is, I want to get rid of the Analysis Title (it was a mistake I wrote Analysis text) and keep the legend. To do that I have to cull away the text but not in all cases the length of the analysis title is the same, so that makes it difficult to use that method. This is not only a wish for "Color Zones by EP Result" but in general for all components with legends. I think it would be easier to just remove or place the Analysis Title without using the reColorMesh. |
@arkdanielnielsen , If you draw up a list of components where this grouping of legend and title outputs happens, I will begin working my way down it (it looks like this issue will take a lot longer to close than initially anticipated :). Feel free to order the list in terms of the components that you would most like to see the change and I will get to those first. -Chris |
Looks good, thanks. |
@chriswmackey finally I had time. In the gh file I have marked all component where the output of AnalysisTitle could be useful.
|
@chriswmackey @arkdanielnielsen what is up with this issue? should we close this? |
@mostaphaRoudsari It is about separating the Analysis Text from the legend output in two separated outputs. To make it easier to remove the text of legend if it is not wanted. And I think it could be useful for all the components with legends. |
@arkdanielnielsen and @mostaphaRoudsari , I have changed the name of the issue to be closer to what we have decided to do. In my view, it is a long-term issue as I have a lot of other priorities on my list and there are a bunch of components to change. All that has to happen is that the code that @arkdanielnielsen posted has to go into a lot of the components and a new output has to be added to them. @arkdanielnielsen , if you want to take this up on your own, that would be swell. Let me know your anticipated time frame and if you run into any issues. |
I just realized that I cannot assign the issue to @arkdanielnielsen . I will put myself back as asignee. |
As requested by @arkdanielnielsen here: ladybug-tools/honeybee-legacy#251 This commit also addresses the request for separate title/legend outputs here: #131
I have gotten this separation of title and legend working now for a large fraction of the Ladybug components. I feel that I should just finish this off for the next stable release. |
This feature will be addressed with the new core Ladybug functions that @mostaphaRoudsari is putting together and so I will let this issue rest until this core development is finished. |
This is a monumental task that we will fix in LB+ but I welcome anyone who wants to implement this on any of the legacy components. |
The text was updated successfully, but these errors were encountered: