diff --git a/.codespellrc b/.codespellrc new file mode 100644 index 000000000..840ffdff2 --- /dev/null +++ b/.codespellrc @@ -0,0 +1,3 @@ +[codespell] +skip = .git,go.sum,go.mod,*.png,*.svg +ignore-words-list = NotIn,te \ No newline at end of file diff --git a/cmd/kurator/app/pipeline/execution/logs/logs.go b/cmd/kurator/app/pipeline/execution/logs/logs.go index 9d660109a..15110f1f4 100644 --- a/cmd/kurator/app/pipeline/execution/logs/logs.go +++ b/cmd/kurator/app/pipeline/execution/logs/logs.go @@ -41,8 +41,8 @@ func NewCmd(opts *generic.Options) *cobra.Command { PipelineList, err := logs.NewPipelineLogs(opts, &Args, pipelineExecutionName) if err != nil { - logrus.Errorf("pipeline excution logs init error: %v", err) - return fmt.Errorf("pipeline excution logs init error: %v", err) + logrus.Errorf("pipeline execution logs init error: %v", err) + return fmt.Errorf("pipeline execution logs init error: %v", err) } logrus.Debugf("start logs pipeline execution obj, Global: %+v ", opts) diff --git a/docs/content/en/docs/Integrations/pixie-vizier.md b/docs/content/en/docs/Integrations/pixie-vizier.md index 949770c6d..079d762d3 100644 --- a/docs/content/en/docs/Integrations/pixie-vizier.md +++ b/docs/content/en/docs/Integrations/pixie-vizier.md @@ -39,8 +39,8 @@ Create a deployment key following the directions [here](https://docs.pixielabs.a Kurator provides a very simple command to install Pixie vizier to all clusters joined to karmada. -- `--cloud-addr` sepcifies the address of the Pixie cloud instance that the vizier should be connected to. -- `--deploy-key` sepcifies the deploy key is used to link the deployed vizier to a specific user/project. +- `--cloud-addr` specifies the address of the Pixie cloud instance that the vizier should be connected to. +- `--deploy-key` specifies the deploy key is used to link the deployed vizier to a specific user/project. ```bash kurator install pixie vizier --deploy-key= diff --git a/docs/content/en/docs/fleet-manager/_index.md b/docs/content/en/docs/fleet-manager/_index.md index 37599e3f2..c857679a2 100644 --- a/docs/content/en/docs/fleet-manager/_index.md +++ b/docs/content/en/docs/fleet-manager/_index.md @@ -31,4 +31,4 @@ The overall architecture of Kurator fleet manager is shown as below: >}} -The Kurator Fleet Manager runs as a kubernetes operator, it is in charge of fleet control plane lifecycle management and also responsible for cluster registeration and un registration. +The Kurator Fleet Manager runs as a kubernetes operator, it is in charge of fleet control plane lifecycle management and also responsible for cluster registration and un registration. diff --git a/docs/content/en/docs/fleet-manager/application.md b/docs/content/en/docs/fleet-manager/application.md index f248f61b0..0a074c2a3 100644 --- a/docs/content/en/docs/fleet-manager/application.md +++ b/docs/content/en/docs/fleet-manager/application.md @@ -247,7 +247,7 @@ kubectl get po -A --kubeconfig=/root/.kube/kurator-member2.config Upon examining the respective clusters, you'll find that applications originating from the same source configuration have been distributed to different clusters based on their respective policy selector labels. -## Playgroud +## Playground Kurator uses killercoda to provide [applications demo](https://killercoda.com/965010e0-4f60-4a28-bf27-597d3kurator/scenario/application-example), allowing users to experience hands-on operations. diff --git a/docs/content/en/docs/fleet-manager/distributedstorage-plugin.md b/docs/content/en/docs/fleet-manager/distributedstorage-plugin.md index 12329289a..7c43d60f1 100644 --- a/docs/content/en/docs/fleet-manager/distributedstorage-plugin.md +++ b/docs/content/en/docs/fleet-manager/distributedstorage-plugin.md @@ -125,7 +125,7 @@ rook-ceph-rgw-ceph-objectstore-a-5c4df48bbb-bf6jn 2/2 Runn ## Persistent Volume Use Guide -After rook opeartor and rook ceph cluster are installed, this chapter provides examples of using Block Storage, Filesystem Storage and Object Storage. +After rook operator and rook ceph cluster are installed, this chapter provides examples of using Block Storage, Filesystem Storage and Object Storage. ### Block Storage Class Configuration @@ -168,8 +168,8 @@ allowVolumeExpansion: true There are a few things to note in the above block storage class configuration: - provisioner is configured in the format (operator-namespace).rbd.csi.ceph.com. Change "rook-ceph" provisioner prefix to match the operator namespace if needed. -- `parametes.clusterID` is the namespace where the rook cluster is running. -- `parametes.pool` is the `CephBlockPool` created before. +- `parameters.clusterID` is the namespace where the rook cluster is running. +- `parameters.pool` is the `CephBlockPool` created before. ### FileSystem Storage Class Configuration @@ -367,7 +367,7 @@ cephfs-pvc Bound filesystem-volume 1Gi RWO 1h In a rook-ceph cluster, the use of object storage is different from the use of block storage and filesystem storage. `ObjectBucketClaim` is used instead of PersistentVolumeClaim. And the application needs secret and configmap to access the objectbucket. When Pod use object storage, they don't mount PVC like block storage and filesystem storage, but instead uniquely specify the ObjectBucketClaim with secret and configmap. -We stil can can ues Kurator application to create ObjectBucketClaim and Pod that consume it, but there will be some changes to the configuration. +We can still use Kurator application to create ObjectBucketClaim and Pod that consume it, but there will be some changes to the configuration. ```console kubectl apply -f - <Application (Optional)

Destination defines the destination clusters where the artifacts will be synced. -It can be overriden by the syncPolicies’ destination.

+It can be overridden by the syncPolicies’ destination.

@@ -346,7 +346,7 @@

ApplicationSpec (Optional)

Destination defines the destination clusters where the artifacts will be synced. -It can be overriden by the syncPolicies’ destination.

+It can be overridden by the syncPolicies’ destination.

@@ -2306,7 +2306,7 @@

Webhook (Optional) -

Commands define to commends that executed by webhook.

+

Commands define to commands that executed by webhook.

diff --git a/docs/content/en/references/fleet_v1alpha1_types.html b/docs/content/en/references/fleet_v1alpha1_types.html index c620ae7a6..2f7833f92 100644 --- a/docs/content/en/references/fleet_v1alpha1_types.html +++ b/docs/content/en/references/fleet_v1alpha1_types.html @@ -1430,7 +1430,7 @@

PluginConfig -

Flagger defines the configuretion for the kurator rollout engine.

+

Flagger defines the configuration for the kurator rollout engine.

diff --git a/docs/proposals/rollout/rollout.md b/docs/proposals/rollout/rollout.md index b8f24277b..3ff9c5212 100644 --- a/docs/proposals/rollout/rollout.md +++ b/docs/proposals/rollout/rollout.md @@ -439,7 +439,7 @@ type Webhook struct { // Defaults to 60 TimeoutSeconds *int `json:"timeoutSeconds,omitempty"` - // Command defines to commends that executed by webhook. + // Command defines to commands that executed by webhook. // +optional Command []string `json:"command,omitempty"` } diff --git a/hack/util.sh b/hack/util.sh index 783192429..f25a76e45 100755 --- a/hack/util.sh +++ b/hack/util.sh @@ -98,7 +98,7 @@ function util::wait_file_exist() { } # util::wait_pod_ready waits for pod state becomes ready until timeout. -# Parmeters: +# Parameters: # - $1: pod label, such as "app=etcd" # - $2: pod namespace, such as "karmada-system" # - $3: time out, such as "200s" @@ -121,7 +121,7 @@ function util::wait_pod_ready() { } # util::wait_apiservice_ready waits for apiservice state becomes Available until timeout. -# Parmeters: +# Parameters: # - $1: apiservice label, such as "app=etcd" # - $3: time out, such as "200s" function util::wait_apiservice_ready() { @@ -141,7 +141,7 @@ function util::wait_apiservice_ready() { # util::create_cluster creates a kubernetes cluster # util::create_cluster creates a kind cluster and don't wait for control plane node to be ready. -# Parmeters: +# Parameters: # - $1: cluster name, such as "host" # - $2: KUBECONFIG file, such as "/var/run/host.config" # - $3: node docker image to use for booting the cluster, such as "kindest/node:v1.19.1" diff --git a/manifests/charts/cluster-operator/crds/kubeadmconfigs.bootstrap.cluster.x-k8s.io.yaml b/manifests/charts/cluster-operator/crds/kubeadmconfigs.bootstrap.cluster.x-k8s.io.yaml index 1da61d8ad..02e644816 100755 --- a/manifests/charts/cluster-operator/crds/kubeadmconfigs.bootstrap.cluster.x-k8s.io.yaml +++ b/manifests/charts/cluster-operator/crds/kubeadmconfigs.bootstrap.cluster.x-k8s.io.yaml @@ -616,7 +616,7 @@ spec: criSocket: description: CRISocket is used to retrieve container runtime info. This information will be annotated to the Node API - object, for later re-use + object, for later reuse type: string ignorePreflightErrors: description: IgnorePreflightErrors provides a slice of pre-flight @@ -722,7 +722,7 @@ spec: type: string caCertPath: description: 'CACertPath is the path to the SSL certificate authority - used to secure comunications between node and control-plane. + used to secure communications between node and control-plane. Defaults to "/etc/kubernetes/pki/ca.crt". TODO: revisit when there is defaulting from k/k' type: string @@ -827,7 +827,7 @@ spec: criSocket: description: CRISocket is used to retrieve container runtime info. This information will be annotated to the Node API - object, for later re-use + object, for later reuse type: string ignorePreflightErrors: description: IgnorePreflightErrors provides a slice of pre-flight diff --git a/manifests/charts/cluster-operator/crds/kubeadmconfigtemplates.bootstrap.cluster.x-k8s.io.yaml b/manifests/charts/cluster-operator/crds/kubeadmconfigtemplates.bootstrap.cluster.x-k8s.io.yaml index 868df0389..d39dbffd0 100755 --- a/manifests/charts/cluster-operator/crds/kubeadmconfigtemplates.bootstrap.cluster.x-k8s.io.yaml +++ b/manifests/charts/cluster-operator/crds/kubeadmconfigtemplates.bootstrap.cluster.x-k8s.io.yaml @@ -655,7 +655,7 @@ spec: criSocket: description: CRISocket is used to retrieve container runtime info. This information will be annotated - to the Node API object, for later re-use + to the Node API object, for later reuse type: string ignorePreflightErrors: description: IgnorePreflightErrors provides a slice @@ -769,7 +769,7 @@ spec: type: string caCertPath: description: 'CACertPath is the path to the SSL certificate - authority used to secure comunications between node + authority used to secure communications between node and control-plane. Defaults to "/etc/kubernetes/pki/ca.crt". TODO: revisit when there is defaulting from k/k' type: string @@ -881,7 +881,7 @@ spec: criSocket: description: CRISocket is used to retrieve container runtime info. This information will be annotated - to the Node API object, for later re-use + to the Node API object, for later reuse type: string ignorePreflightErrors: description: IgnorePreflightErrors provides a slice diff --git a/manifests/charts/cluster-operator/crds/kubeadmcontrolplanes.controlplane.cluster.x-k8s.io.yaml b/manifests/charts/cluster-operator/crds/kubeadmcontrolplanes.controlplane.cluster.x-k8s.io.yaml index ddd963252..d89bca9b5 100755 --- a/manifests/charts/cluster-operator/crds/kubeadmcontrolplanes.controlplane.cluster.x-k8s.io.yaml +++ b/manifests/charts/cluster-operator/crds/kubeadmcontrolplanes.controlplane.cluster.x-k8s.io.yaml @@ -674,7 +674,7 @@ spec: criSocket: description: CRISocket is used to retrieve container runtime info. This information will be annotated to the Node - API object, for later re-use + API object, for later reuse type: string ignorePreflightErrors: description: IgnorePreflightErrors provides a slice of @@ -786,7 +786,7 @@ spec: type: string caCertPath: description: 'CACertPath is the path to the SSL certificate - authority used to secure comunications between node and + authority used to secure communications between node and control-plane. Defaults to "/etc/kubernetes/pki/ca.crt". TODO: revisit when there is defaulting from k/k' type: string @@ -894,7 +894,7 @@ spec: criSocket: description: CRISocket is used to retrieve container runtime info. This information will be annotated to the Node - API object, for later re-use + API object, for later reuse type: string ignorePreflightErrors: description: IgnorePreflightErrors provides a slice of diff --git a/manifests/charts/cluster-operator/crds/kubeadmcontrolplanetemplates.controlplane.cluster.x-k8s.io.yaml b/manifests/charts/cluster-operator/crds/kubeadmcontrolplanetemplates.controlplane.cluster.x-k8s.io.yaml index d0469efd9..dd8de5330 100755 --- a/manifests/charts/cluster-operator/crds/kubeadmcontrolplanetemplates.controlplane.cluster.x-k8s.io.yaml +++ b/manifests/charts/cluster-operator/crds/kubeadmcontrolplanetemplates.controlplane.cluster.x-k8s.io.yaml @@ -689,7 +689,7 @@ spec: criSocket: description: CRISocket is used to retrieve container runtime info. This information will be annotated - to the Node API object, for later re-use + to the Node API object, for later reuse type: string ignorePreflightErrors: description: IgnorePreflightErrors provides a @@ -807,7 +807,7 @@ spec: type: string caCertPath: description: 'CACertPath is the path to the SSL certificate - authority used to secure comunications between node + authority used to secure communications between node and control-plane. Defaults to "/etc/kubernetes/pki/ca.crt". TODO: revisit when there is defaulting from k/k' type: string @@ -925,7 +925,7 @@ spec: criSocket: description: CRISocket is used to retrieve container runtime info. This information will be annotated - to the Node API object, for later re-use + to the Node API object, for later reuse type: string ignorePreflightErrors: description: IgnorePreflightErrors provides a diff --git a/manifests/charts/fleet-manager/crds/apps.kurator.dev_applications.yaml b/manifests/charts/fleet-manager/crds/apps.kurator.dev_applications.yaml index 3fb6f0c2c..f553c477a 100644 --- a/manifests/charts/fleet-manager/crds/apps.kurator.dev_applications.yaml +++ b/manifests/charts/fleet-manager/crds/apps.kurator.dev_applications.yaml @@ -45,7 +45,7 @@ spec: destination: description: |- Destination defines the destination clusters where the artifacts will be synced. - It can be overriden by the syncPolicies' destination. + It can be overridden by the syncPolicies' destination. properties: clusterSelector: description: |- @@ -729,7 +729,7 @@ spec: type: object replace: description: |- - Replace tells the Helm install action to re-use the 'ReleaseName', but only + Replace tells the Helm install action to reuse the 'ReleaseName', but only if that name is a deleted release which remains in the history. type: boolean skipCRDs: @@ -1360,7 +1360,7 @@ spec: description: Webhook list for this traffic analysis properties: command: - description: Commands define to commends that + description: Commands define to commands that executed by webhook. items: type: string diff --git a/manifests/charts/fleet-manager/crds/fleet.kurator.dev_fleets.yaml b/manifests/charts/fleet-manager/crds/fleet.kurator.dev_fleets.yaml index bd951dc73..988b7af27 100644 --- a/manifests/charts/fleet-manager/crds/fleet.kurator.dev_fleets.yaml +++ b/manifests/charts/fleet-manager/crds/fleet.kurator.dev_fleets.yaml @@ -2462,7 +2462,7 @@ spec: - storage type: object flagger: - description: Flagger defines the configuretion for the kurator + description: Flagger defines the configuration for the kurator rollout engine. properties: chart: diff --git a/manifests/profiles/prom-thanos/setup/prometheus-operator-0alertmanagerCustomResourceDefinition.yaml b/manifests/profiles/prom-thanos/setup/prometheus-operator-0alertmanagerCustomResourceDefinition.yaml index d97177762..032145bd1 100644 --- a/manifests/profiles/prom-thanos/setup/prometheus-operator-0alertmanagerCustomResourceDefinition.yaml +++ b/manifests/profiles/prom-thanos/setup/prometheus-operator-0alertmanagerCustomResourceDefinition.yaml @@ -2639,7 +2639,7 @@ spec: conditions: description: Current Condition of persistent volume claim. If underlying persistent volume is being resized then the Condition will be set to 'ResizeStarted'. items: - description: PersistentVolumeClaimCondition contails details about state of pvc + description: PersistentVolumeClaimCondition contains details about state of pvc properties: lastProbeTime: description: Last time we probed the condition. diff --git a/manifests/profiles/prom-thanos/setup/prometheus-operator-0prometheusCustomResourceDefinition.yaml b/manifests/profiles/prom-thanos/setup/prometheus-operator-0prometheusCustomResourceDefinition.yaml index e361d8c8e..8678fd472 100644 --- a/manifests/profiles/prom-thanos/setup/prometheus-operator-0prometheusCustomResourceDefinition.yaml +++ b/manifests/profiles/prom-thanos/setup/prometheus-operator-0prometheusCustomResourceDefinition.yaml @@ -3975,7 +3975,7 @@ spec: conditions: description: Current Condition of persistent volume claim. If underlying persistent volume is being resized then the Condition will be set to 'ResizeStarted'. items: - description: PersistentVolumeClaimCondition contails details about state of pvc + description: PersistentVolumeClaimCondition contains details about state of pvc properties: lastProbeTime: description: Last time we probed the condition. diff --git a/manifests/profiles/prom-thanos/setup/prometheus-operator-0thanosrulerCustomResourceDefinition.yaml b/manifests/profiles/prom-thanos/setup/prometheus-operator-0thanosrulerCustomResourceDefinition.yaml index b9b3f2795..c78fc4653 100644 --- a/manifests/profiles/prom-thanos/setup/prometheus-operator-0thanosrulerCustomResourceDefinition.yaml +++ b/manifests/profiles/prom-thanos/setup/prometheus-operator-0thanosrulerCustomResourceDefinition.yaml @@ -2801,7 +2801,7 @@ spec: conditions: description: Current Condition of persistent volume claim. If underlying persistent volume is being resized then the Condition will be set to 'ResizeStarted'. items: - description: PersistentVolumeClaimCondition contails details about state of pvc + description: PersistentVolumeClaimCondition contains details about state of pvc properties: lastProbeTime: description: Last time we probed the condition. diff --git a/manifests/profiles/prom/setup/prometheus-operator-0alertmanagerCustomResourceDefinition.yaml b/manifests/profiles/prom/setup/prometheus-operator-0alertmanagerCustomResourceDefinition.yaml index d97177762..032145bd1 100644 --- a/manifests/profiles/prom/setup/prometheus-operator-0alertmanagerCustomResourceDefinition.yaml +++ b/manifests/profiles/prom/setup/prometheus-operator-0alertmanagerCustomResourceDefinition.yaml @@ -2639,7 +2639,7 @@ spec: conditions: description: Current Condition of persistent volume claim. If underlying persistent volume is being resized then the Condition will be set to 'ResizeStarted'. items: - description: PersistentVolumeClaimCondition contails details about state of pvc + description: PersistentVolumeClaimCondition contains details about state of pvc properties: lastProbeTime: description: Last time we probed the condition. diff --git a/manifests/profiles/prom/setup/prometheus-operator-0prometheusCustomResourceDefinition.yaml b/manifests/profiles/prom/setup/prometheus-operator-0prometheusCustomResourceDefinition.yaml index e361d8c8e..8678fd472 100644 --- a/manifests/profiles/prom/setup/prometheus-operator-0prometheusCustomResourceDefinition.yaml +++ b/manifests/profiles/prom/setup/prometheus-operator-0prometheusCustomResourceDefinition.yaml @@ -3975,7 +3975,7 @@ spec: conditions: description: Current Condition of persistent volume claim. If underlying persistent volume is being resized then the Condition will be set to 'ResizeStarted'. items: - description: PersistentVolumeClaimCondition contails details about state of pvc + description: PersistentVolumeClaimCondition contains details about state of pvc properties: lastProbeTime: description: Last time we probed the condition. diff --git a/manifests/profiles/prom/setup/prometheus-operator-0thanosrulerCustomResourceDefinition.yaml b/manifests/profiles/prom/setup/prometheus-operator-0thanosrulerCustomResourceDefinition.yaml index b9b3f2795..c78fc4653 100644 --- a/manifests/profiles/prom/setup/prometheus-operator-0thanosrulerCustomResourceDefinition.yaml +++ b/manifests/profiles/prom/setup/prometheus-operator-0thanosrulerCustomResourceDefinition.yaml @@ -2801,7 +2801,7 @@ spec: conditions: description: Current Condition of persistent volume claim. If underlying persistent volume is being resized then the Condition will be set to 'ResizeStarted'. items: - description: PersistentVolumeClaimCondition contails details about state of pvc + description: PersistentVolumeClaimCondition contains details about state of pvc properties: lastProbeTime: description: Last time we probed the condition. diff --git a/pkg/apis/apps/v1alpha1/types.go b/pkg/apis/apps/v1alpha1/types.go index 78c6c9493..7778b17f5 100644 --- a/pkg/apis/apps/v1alpha1/types.go +++ b/pkg/apis/apps/v1alpha1/types.go @@ -46,7 +46,7 @@ type ApplicationSpec struct { // SyncPolicies controls how the artifact will be customized and where it will be synced. SyncPolicies []*ApplicationSyncPolicy `json:"syncPolicies"` // Destination defines the destination clusters where the artifacts will be synced. - // It can be overriden by the syncPolicies' destination. + // It can be overridden by the syncPolicies' destination. // +optional Destination *ApplicationDestination `json:"destination,omitempty"` } @@ -411,7 +411,7 @@ type Webhook struct { // Defaults to 60 TimeoutSeconds *int `json:"timeoutSeconds,omitempty"` - // Commands define to commends that executed by webhook. + // Commands define to commands that executed by webhook. // +optional Commands []string `json:"command,omitempty"` } diff --git a/pkg/apis/cluster/v1alpha1/cluster_consts.go b/pkg/apis/cluster/v1alpha1/cluster_consts.go index 9f53bff81..e02fa0766 100644 --- a/pkg/apis/cluster/v1alpha1/cluster_consts.go +++ b/pkg/apis/cluster/v1alpha1/cluster_consts.go @@ -41,7 +41,7 @@ const ( ProvisioningReason = "Provisioning" // DeletingReason (Severity=Info) documents that the cluster is being deleted. DeletingReason = "Deleting" - // ProviderInitializeFailedReason (Severity=Error) documents that the cluster infrastructure provider initilize failed, probabily a wrong credential. + // ProviderInitializeFailedReason (Severity=Error) documents that the cluster infrastructure provider initialize failed, probably a wrong credential. ProviderInitializeFailedReason = "ProviderInitializeFailed" // ClusterResourceSetProvisionFailedReason (Severity=Error) documents that the additional Cluster API resources (ClusterResourceSet etc.) provisioning failed. diff --git a/pkg/apis/fleet/v1alpha1/types.go b/pkg/apis/fleet/v1alpha1/types.go index 038d31b5a..f88af91c6 100644 --- a/pkg/apis/fleet/v1alpha1/types.go +++ b/pkg/apis/fleet/v1alpha1/types.go @@ -85,7 +85,7 @@ type PluginConfig struct { Backup *BackupConfig `json:"backup,omitempty"` // DistributedStorage define the configuration for the distributed storage(Implemented with Rook) DistributedStorage *DistributedStorageConfig `json:"distributedStorage,omitempty"` - // Flagger defines the configuretion for the kurator rollout engine. + // Flagger defines the configuration for the kurator rollout engine. Flagger *FlaggerConfig `json:"flagger,omitempty"` } diff --git a/pkg/client/client.go b/pkg/client/client.go index 43fc6d618..2b445831c 100644 --- a/pkg/client/client.go +++ b/pkg/client/client.go @@ -139,7 +139,7 @@ func (c *Client) UpdateResource(obj interface{}) error { return err } -// Copied from karmada, because we donot want to build the controller-runtime client. +// Copied from karmada, because we do not want to build the controller-runtime client. func (c *Client) memberClusterConfig(clusterName string) (*rest.Config, error) { cluster, err := c.karmada.ClusterV1alpha1().Clusters().Get(context.TODO(), clusterName, metav1.GetOptions{}) if err != nil { diff --git a/pkg/fleet-manager/controlplane.go b/pkg/fleet-manager/controlplane.go index 38b2231bf..1a81ef4f3 100644 --- a/pkg/fleet-manager/controlplane.go +++ b/pkg/fleet-manager/controlplane.go @@ -37,7 +37,7 @@ const FleetWorkerClusterRoleBindingName = "fleet-worker" func (f *FleetManager) reconcileControlPlane(ctx context.Context, fleet *fleetapi.Fleet) error { controlplane := fleet.Annotations[fleetapi.ControlplaneAnnotation] // if no controlplane is specified, do nothing - // we donot support annotation update yet + // we do not support annotation update yet if controlplane == "" { fleet.Status.Phase = fleetapi.ReadyPhase fleet.Status.CredentialSecret = nil diff --git a/pkg/plugin/istio/install.go b/pkg/plugin/istio/install.go index 9d4c8cc83..d7a44080f 100644 --- a/pkg/plugin/istio/install.go +++ b/pkg/plugin/istio/install.go @@ -69,7 +69,7 @@ func (p *IstioPlugin) runInstall() error { return err } - if err := p.overrideNamespaceIfNeeded(); err != nil { + if err := p.overriddenamespaceIfNeeded(); err != nil { return err } @@ -114,7 +114,7 @@ func (p *IstioPlugin) ensureNamespaces() error { return nil } -func (p *IstioPlugin) overrideNamespaceIfNeeded() error { +func (p *IstioPlugin) overriddenamespaceIfNeeded() error { for _, c := range p.allClusters() { network := clusterNetwork{ IstioSystemNamespace: istioSystemNamespace,