Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit 0 after checking addon configmap existences #3143

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 3, 2025

Fixes https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-no-addons-latest
Fixes #3144


# task-08-check-addons-after-upgrade
/bin/sh -c docker exec kinder-upgrade-control-plane-1 kubectl get cm kube-proxy -n kube-system --kubeconfig /etc/kubernetes/admin.conf && exit 1
docker exec kinder-upgrade-control-plane-1 kubectl get cm coredns -n kube-system --kubeconfig /etc/kubernetes/admin.conf && exit 1
Error from server (NotFound): configmaps "kube-proxy" not found
Error from server (NotFound): configmaps "coredns" not found
 exit status 1

/cc @neolit123

@k8s-ci-robot k8s-ci-robot requested a review from neolit123 January 3, 2025 06:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kinder Issues to track work in the kinder tool approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2025
@pacoxu
Copy link
Member Author

pacoxu commented Jan 3, 2025

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still don't exactly understand why this is needed, but we do have it in other places. so LGTM.

thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9a0f0dc into kubernetes:main Jan 3, 2025
4 checks passed
@neolit123
Copy link
Member

i still don't exactly understand why this is needed, but we do have it in other places. so LGTM.

thanks /lgtm

i guess it just takes the exit status of the last failed command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test ubeadm-kinder-no-addons-latest
3 participants