Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v1beta2 API #5922

Open
jbartosik opened this issue Jul 3, 2023 · 9 comments · May be fixed by #7629
Open

Remove v1beta2 API #5922

jbartosik opened this issue Jul 3, 2023 · 9 comments · May be fixed by #7629
Assignees
@adrianmoisey
Labels
area/vertical-pod-autoscaler kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@jbartosik
Copy link
Collaborator

Follow up to #4969, remove the deprecated API.

Beta API versions must be supported for 9 months or 3 releases (whichever is longer) after deprecation

Deprecation was in VPA 0.13.0, which was released on 2023-02-03; In the mean time we had VPA 0.14.0.

So the next VPA can't drop the API yet (it will be 3rd one). We also need to wait at least until 2023-11-03 before dropping the API.

So likely the release triggered by K8s 1.28 in August keeps the API.

And the release triggered by K8s 1.29 can drop it.
@jbartosik jbartosik added area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jul 3, 2023
@Shubham82
Copy link
Contributor

Any update on this issue, as current k8s version is k8s v1.31and v1beta2 API (with depricated message) is still present in vpa-v1-crd-gen.yaml file.

@Shubham82
Copy link
Contributor

cc @jbartosik @voelzmo @kwiesmueller

@voelzmo
Copy link
Contributor

voelzmo commented Oct 28, 2024

Agreed, we should be able to drop this now and document that the new release won't work with k8s versions < v1.29

@raywainman
Copy link
Contributor

SGTM

@adrianmoisey
Copy link
Member

Agreed, we should be able to drop this now and document that the new release won't work with k8s versions < v1.29

Isn't the removal of the CRD/API related to the VPA version and not the Kubernetes version?

@raywainman
Copy link
Contributor

We've been trying to release a VPA version roughly every k8s minor version so that's likely what Joachim was meaning here.

@adrianmoisey
Copy link
Member

We've been trying to release a VPA version roughly every k8s minor version so that's likely what Joachim was meaning here.

Oh interesting, I never knew that.
Since that's not a promise we make to users (directly or indirectly) I'd suggest that the communication about deprecation references which version of the VPA drops support, not which versions of Kubernetes drop support.

@adrianmoisey
Copy link
Member

Since that's not a promise we make to users (directly or indirectly)

I see we do have it written down here:

autoscaler/vertical-pod-autoscaler/RELEASE.md

Lines 3 to 4 in 16210e3

These are instructions for releasing VPA. We aim to release a new VPA minor version after each minor Kubernetes release.
We release patch versions as needed.

So we do kinda promise it to the user, I guess.

@adrianmoisey
Copy link
Member

/assign

@adrianmoisey adrianmoisey linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianmoisey adrianmoisey

Labels
area/vertical-pod-autoscaler kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VPA: Remove v1beta2 adrianmoisey/autoscaler
5 participants
@jbartosik @raywainman @adrianmoisey @voelzmo @Shubham82