Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CR Restrictions e2e tests #1879

Closed
TessaIO opened this issue Sep 17, 2024 · 4 comments · Fixed by #1990
Closed

Improve CR Restrictions e2e tests #1879

TessaIO opened this issue Sep 17, 2024 · 4 comments · Fixed by #1990
Assignees
@TessaIO
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@TessaIO
Copy link
Member

TessaIO commented Sep 17, 2024

What would you like to be added:

  • Test the case where we have a non 3rd party NodeFeature and the disableFeatureLabels restriction
  • Add utility to patch namespaces

Why is this needed:

  • Cover more edge cases and improve confidence in the feature. Hopefully, we can remove the experimental flag.
@TessaIO TessaIO added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 17, 2024
@TessaIO
Copy link
Member Author

TessaIO commented Sep 17, 2024

FYI @marquiz
/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2024
@TessaIO TessaIO mentioned this issue Dec 19, 2024
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 15, 2025
@TessaIO
Copy link
Member Author

TessaIO commented Jan 15, 2025

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TessaIO TessaIO

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
3 participants
@k8s-ci-robot @k8s-triage-robot @TessaIO