Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use strict config parsing #907

Closed
dlipovetsky opened this issue Oct 2, 2019 · 6 comments
Closed

use strict config parsing #907

dlipovetsky opened this issue Oct 2, 2019 · 6 comments
Assignees
@BenTheElder
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.

Comments

@dlipovetsky
Copy link
Contributor

dlipovetsky commented Oct 2, 2019 •
edited
Loading

What would you like to be added:
When I pass a configuration file to kind, e.g., to define extra mounts for the containers, I would like some confirmation that it read and applied this configuration.

This is not output in the debug or trace-level logs.

Why is this needed:
The non-strict unmarshalling ignores configuration malformed in a specific way (e.g. extraMounts field has a typo). So it would be nice to realize this without having to resort to inspecting the container after it's up.
@dlipovetsky dlipovetsky added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 2, 2019
@BenTheElder
Copy link
Member

I plan to switch to strict marshaling O(soon).

@dlipovetsky
Copy link
Contributor Author

Strict marshaling would be... strictly better 😄

@BenTheElder BenTheElder mentioned this issue Oct 3, 2019
Closed
@BenTheElder BenTheElder self-assigned this Oct 7, 2019
@BenTheElder
Copy link
Member

I've got two PRs open for strict marshalling, just need to do a little more work to determine which route we go forward with.

@BenTheElder BenTheElder added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 7, 2019
@BenTheElder BenTheElder changed the title Output the kind configuration applied use strict config parsing Oct 14, 2019
@BenTheElder
Copy link
Member

(hijacking this to track that actually merging)

@BenTheElder
Copy link
Member

we have some strict config loading now 😅

@BenTheElder
Copy link
Member

#912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenTheElder BenTheElder

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update apimachinery and enable strict decoding BenTheElder/kind
2 participants
@BenTheElder @dlipovetsky