[backend] Incorrect run status reporting for Runs using ExitHandler #11405
Assignees
Labels
Comments
|
/assign @DharmitD |
|
/assign @mprahl |
mprahl
added a commit
to mprahl/pipelines
that referenced
this issue
Dec 17, 2024
As described in kubeflow#10917, exit handlers were implemented as dependent tasks that always ran within an Argo Workflow. The issue is that this caused the pipeline to have a succeeded status regardless of if the tasks within the exit handlers all succeeded. This commit changes exit handlers to be exit lifecycle hooks on an Argo Workflow so that the overall pipeline status is not impacted. Resolves: kubeflow#11405 Signed-off-by: mprahl <[email protected]>
2 tasks
mprahl
added a commit
to mprahl/pipelines
that referenced
this issue
Jan 2, 2025
As described in kubeflow#10917, exit handlers were implemented as dependent tasks that always ran within an Argo Workflow. The issue is that this caused the pipeline to have a succeeded status regardless of if the tasks within the exit handlers all succeeded. This commit changes exit handlers to be exit lifecycle hooks on an Argo Workflow so that the overall pipeline status is not impacted. Resolves: kubeflow#11405 Signed-off-by: mprahl <[email protected]>
mprahl
added a commit
to mprahl/pipelines
that referenced
this issue
Jan 9, 2025
As described in kubeflow#10917, exit handlers were implemented as dependent tasks that always ran within an Argo Workflow. The issue is that this caused the pipeline to have a succeeded status regardless of if the tasks within the exit handlers all succeeded. This commit changes exit handlers to be exit lifecycle hooks on an Argo Workflow so that the overall pipeline status is not impacted. Resolves: kubeflow#11405 Signed-off-by: mprahl <[email protected]>
mprahl
added a commit
to mprahl/pipelines
that referenced
this issue
Jan 10, 2025
As described in kubeflow#10917, exit handlers were implemented as dependent tasks that always ran within an Argo Workflow. The issue is that this caused the pipeline to have a succeeded status regardless of if the tasks within the exit handlers all succeeded. This commit changes exit handlers to be exit lifecycle hooks on an Argo Workflow so that the overall pipeline status is not impacted. Resolves: kubeflow#11405 Signed-off-by: mprahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Pipeline overall run status inaccurately reports
Succeededwhen using anExitHandlerthat includes a failing task, but succeedingexit_taskSuggested solution and more context can be found here. In short, we should try to first attempt to use Argo lifecycle hooks when creating the dag task for the
exit_task.Steps to reproduce
To reproduce this, use the following attached pipeline.
exithandler-v2-yaml.txt
Expected result
pipeline run should report accurate status if a task in an exit handler task group fails.
Materials and Reference
Impacted by this bug? Give it a 👍.
The text was updated successfully, but these errors were encountered: