-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate guarantee that mk8sv is satisified #1611
Comments
It's funny because we do run the tests on both versions, but there's clearly a gap here since this got through. Thanks for raising. |
Yeah it's runtime vs compilation - the new version will run on older clusters, just won't compile with "old" openapi |
Yeah. Tbh, this is a reason why parts of me wants to drop k8s-openapi's version choice and turn it into fixed
It's also the versioning strategy most other kubernetes tools on the go side uses (update client-go? cool, dont' stray too far, here's a compatibility matrix, but you get updated structs anyway). The alternative here is doing more like what we do in the |
Okay, sounds like a good plan to me. It's less backward compatible but good trade offs in terms of usability/maintenance and if it's the standard then no reason to stray from that. |
Followup from:
Originally posted by @aviramha in #1605 (comment)
An innocent change broke that guarantee and could've slipped to a release.
Opening this issue to discuss how we can guarantee that this doesn't happen in the future.
My suggestion is to change the dev dependency of openapi to use mk8sv (perhaps run tests both on latest and mk8sv?)
Happy to hear other suggestions
The text was updated successfully, but these errors were encountered: