From f1b97dd260c0472856abb6fcb20f2b951867ffe1 Mon Sep 17 00:00:00 2001 From: Kristoffer Dalby Date: Mon, 9 Dec 2024 09:18:43 +0100 Subject: [PATCH] document upgrading of modernc libs Signed-off-by: Kristoffer Dalby --- go.mod | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/go.mod b/go.mod index e9f9ff42439..20d89aab328 100644 --- a/go.mod +++ b/go.mod @@ -52,6 +52,30 @@ require ( zombiezen.com/go/postgrestest v1.0.1 ) +// NOTE: modernc sqlite has a fragile dependency +// chain and it is important that they are updated +// in lockstep to ensure that they do not break +// some architectures and similar at runtime: +// https://github.com/juanfont/headscale/issues/2188 +// +// Fragile libc dependency: +// https://pkg.go.dev/modernc.org/sqlite#hdr-Fragile_modernc_org_libc_dependency +// https://gitlab.com/cznic/sqlite/-/issues/177 +// +// To upgrade, determine the new SQLite version to +// be used, and consult the `go.mod` file: +// https://gitlab.com/cznic/sqlite/-/blob/master/go.mod +// to find +// the appropriate `libc` version, then upgrade them +// together, e.g: +// go get modernc.org/libc@v1.55.3 modernc.org/sqlite@v1.33.1 +require ( + modernc.org/libc v1.55.3 // indirect + modernc.org/mathutil v1.6.0 // indirect + modernc.org/memory v1.8.0 // indirect + modernc.org/sqlite v1.33.1 // indirect +) + require ( atomicgo.dev/cursor v0.2.0 // indirect atomicgo.dev/keyboard v0.2.9 // indirect @@ -204,8 +228,4 @@ require ( google.golang.org/genproto/googleapis/rpc v0.0.0-20240903143218-8af14fe29dc1 // indirect gopkg.in/yaml.v2 v2.4.0 // indirect gvisor.dev/gvisor v0.0.0-20240722211153-64c016c92987 // indirect - modernc.org/libc v1.55.3 // indirect - modernc.org/mathutil v1.6.0 // indirect - modernc.org/memory v1.8.0 // indirect - modernc.org/sqlite v1.33.1 // indirect )