Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Delete dynamic controller on CRD uninstall #54

Closed
wants to merge 1 commit into from
Closed

[WIP] Delete dynamic controller on CRD uninstall #54

wants to merge 1 commit into from

Conversation

aavarghese
Copy link
Contributor

@aavarghese aavarghese commented Nov 30, 2020 •
edited
Loading

Fixes #2
Signed-off-by: Ansu Varghese [email protected]

Changes

@knative-prow-robot
Copy link

@aavarghese: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them

In response to this:

Signed-off-by: Ansu Varghese [email protected]

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2020
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 30, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 30, 2020
@aavarghese
Copy link
Contributor Author

DeleteFunc is only being invoked from here https://github.com/knative-sandbox/eventing-autoscaler-keda/pull/54/files#diff-69bb40776bb0db60ccbb910f85594ecae2365a9a66bae38fcbad218c0124d96aR92 and not as expected from https://github.com/knative-sandbox/eventing-autoscaler-keda/pull/54/files#diff-9f218382398a14e88cf9424a19a54422d028e7df5a80e6d107b8d33052897859R67. So currently unsure of how to proceed....

@aavarghese aavarghese changed the title [WIP] Trying to delete dynamic controller on CRD uninstall [WIP] Delete dynamic controller on CRD uninstall Dec 9, 2020
Base automatically changed from master to main March 4, 2021 16:25
@markusthoemmes markusthoemmes requested review from a team as code owners March 4, 2021 16:25
@markusthoemmes markusthoemmes requested review from a user and removed request for a team March 4, 2021 16:25
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2021
@knative-prow-robot
Copy link

@aavarghese: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2021
@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 26, 2021
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 26, 2021
@markusthoemmes markusthoemmes removed request for a team November 9, 2021 06:55
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2022
@github-actions github-actions bot closed this Mar 10, 2022
@zroubalik zroubalik reopened this Mar 10, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aavarghese
To complete the pull request process, please assign lionelvillard after the PR has been reviewed.
You can assign the PR to them by writing /assign @lionelvillard in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2022
@knative-prow-robot
Copy link

@aavarghese: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-sandbox-eventing-autoscaler-keda-integration-test-kafka-source c42780a link false /test pull-knative-sandbox-eventing-autoscaler-keda-integration-test-kafka-source
pull-knative-sandbox-eventing-autoscaler-keda-integration-test-kafka-mt-source c42780a link false /test pull-knative-sandbox-eventing-autoscaler-keda-integration-test-kafka-mt-source

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierDipi pierDipi removed the request for review from a team April 26, 2022 08:17
@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2022
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2022
@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2022
@knative-prow-robot
Copy link

This pull request is stale because it has been open for 90 days with no activity.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale label is applied
  • After 30d of inactivity since lifecycle/stale label was applied, the issue is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle stale

/close

@knative-prow
Copy link

knative-prow bot commented Dec 25, 2022

@knative-prow-robot: Closed this PR.

In response to this:

This pull request is stale because it has been open for 90 days with no activity.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale label is applied
  • After 30d of inactivity since lifecycle/stale label was applied, the issue is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle stale

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot closed this Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott Awaiting requested review from n3wscott

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uninstalled Event Source results in not properly finalized dynamic controller
3 participants
@aavarghese @knative-prow-robot @zroubalik