Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomerGroup missing #9

Open
bsmietana opened this issue Nov 22, 2024 · 0 comments
Open

CustomerGroup missing #9

bsmietana opened this issue Nov 22, 2024 · 0 comments

Comments

@bsmietana
Copy link

Would you consider slightly adjusting the CustomerPropertiesTranslator?

In line 140 you return $group->getName(), but this sometimes may be null when it shouldn't. Returning $group->getTranslation('name') should ensure that proper translation is used or null if nothing is found.

This has been the case for Shopware 6.5, but we've started migration to Shopware 6.6 and we'd like to check if you can adjust that part on your side?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bsmietana