Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip test] Release v0.23.0 #405

Closed
wants to merge 1 commit into from
Closed

[skip test] Release v0.23.0 #405

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 8, 2024

This is an automated PR to build the latest changelog. Upon merging, a new release will be created and published to crates.io.
Due to security considerations, PRs created by GitHub Actions cannot be merged automatically. Please review the changes and merge the PR.
If you require the test suites to run, you can close the PR and reopen it to trigger those workflows.

@github-actions github-actions bot force-pushed the release/v0.23.0 branch from 2e91b27 to c7ab9d1 Compare May 8, 2024 19:55
@github-actions github-actions bot enabled auto-merge May 8, 2024 19:55
@kivikakk
Copy link
Owner

kivikakk commented May 8, 2024

lol, okay. Closing #404 triggered this, just as closing #395 triggered that.

@gjtorikian
Copy link
Collaborator

That's super weird; this PR should only open on a manual workflow dispatch 🤔 Is this more trouble than it's worth?

@kivikakk
Copy link
Owner

kivikakk commented May 9, 2024

I had a noodle and suddenly realised: do we need an if: on the prepare job too? We do the workflow on closed PRs …

pull_request_target:
types:
- closed

but we don't have any condition on prepare, which is what creates the PR:

jobs:
prepare:
runs-on: ubuntu-latest
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
outputs:
version: ${{ steps.version-label.outputs.version }}
steps:
- uses: actions/checkout@v4
with:
submodules: true

vs.

release:
if: ${{ (github.event.pull_request.merged == true) && (contains(github.event.pull_request.labels.*.name, 'release')) }}
runs-on: ubuntu-latest
env:
CRATES_IO_TOKEN: ${{ secrets.CRATES_IO_TOKEN }}
steps:
- uses: actions/checkout@v4

@kivikakk
Copy link
Owner

kivikakk commented May 9, 2024

I'll try pushing a condition direct to main, then close this to see if we get a new one.

@kivikakk kivikakk closed this May 9, 2024
auto-merge was automatically disabled May 9, 2024 15:19

Pull request was closed

@kivikakk kivikakk deleted the release/v0.23.0 branch May 9, 2024 15:19
@kivikakk
Copy link
Owner

kivikakk commented May 9, 2024

Success — no new PR.

@digitalmoksha
Copy link
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants