Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ComrakParseOptions and similar #[non_exhaustive] #321

Closed
tgross35 opened this issue Jun 16, 2023 · 1 comment · Fixed by #305
Closed

Mark ComrakParseOptions and similar #[non_exhaustive] #321

tgross35 opened this issue Jun 16, 2023 · 1 comment · Fixed by #305

Comments

@tgross35
Copy link
Contributor

This will allow for adding more configuration fields in the future without breaking compatibility (it seems like some issues may be requesting this). However, this itself would be a breaking change; users would need to change from e.g.

let opts = ComrakParseOptions {
    smart: true
    default_info_string: None,
    relaxed_tasklist_matching: true,
}

to:

let opts = ComrakParseOptions {
    smart: true
    default_info_string: None,
    relaxed_tasklist_matching: true,
    ..Default::default()
}
@tgross35
Copy link
Contributor Author

Ah, this is actually handled in #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant