Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema Validator dependency is in maintenance mode. Consider alternatives. #262

Open
Pfeil opened this issue Jan 23, 2025 · 1 comment · May be fixed by #272
Open

JSON Schema Validator dependency is in maintenance mode. Consider alternatives. #262

Pfeil opened this issue Jan 23, 2025 · 1 comment · May be fixed by #272
Assignees
Labels
maintenance Not a bug, but should be done.
Milestone

Comments

@Pfeil
Copy link
Member

Pfeil commented Jan 23, 2025

Is your feature request related to a problem? Please describe.

The current json schema validator we use is in maintenance mode. It is also not the one we use in other projects.

Describe the solution you'd like

We should consider using the fork which is proposed from the project or https://github.com/networknt/json-schema-validator

@Pfeil Pfeil added the maintenance Not a bug, but should be done. label Jan 23, 2025
@Pfeil
Copy link
Member Author

Pfeil commented Jan 24, 2025

It also seems to not support the format = uri feature in the schema generated for this type like this:

curl -X 'GET' \
  'http://typeapi.lab.pidconsortium.net/v1/types/schema/21.T11969/cb371c93c5aa0e62198e' \
  -H 'accept: application/json'
{
    "@id": "21.T11969/cb371c93c5aa0e62198e",
    "type": "string",
    "format": "uri",
    "description": "Validation schema for type 'URI' with the PID '21.T11969/cb371c93c5aa0e62198e'",
    "title": "URI",
    "$schema": "http://json-schema.org/draft-04/schema#"
}

I did not test if it would have to, but we should make sure to have a feature-complete validator. The current validator just allows any string, given this schema.

@Pfeil Pfeil added this to the 3.0.0 milestone Jan 26, 2025
@Pfeil Pfeil self-assigned this Jan 28, 2025
@Pfeil Pfeil linked a pull request Jan 29, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug, but should be done.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant