Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtendedErrorAttributes are not invoked anymore #258

Open
Pfeil opened this issue Jan 15, 2025 · 1 comment · May be fixed by #270
Open

ExtendedErrorAttributes are not invoked anymore #258

Pfeil opened this issue Jan 15, 2025 · 1 comment · May be fixed by #270
Labels
bug Something isn't working
Milestone

Comments

@Pfeil
Copy link
Member

Pfeil commented Jan 15, 2025

Describe the bug
This class ExtededErrorAttributes is supposed to add a pit-record attribute, which, in case of validation errors, will attach the affected record. But this does not seem to work. (Discovered by looking at the test testResolvingInvalidRecordWithValidationFail, confirmed in others).

To Reproduce
Steps to reproduce the behavior:

  1. run testResolvingInvalidRecordWithValidationFail (or in master branch, for example testInvalidRecordWithProfile)
  2. Check response

Expected behavior
include record encoded in pid-record key

Possible Starting points for a solution

https://github.com/maximiliani/idoris/blob/main/src/main/java/edu/kit/datamanager/idoris/configuration/RestResponseEntityExceptionHandler.java

@Pfeil Pfeil added bug Something isn't working documentation Improvements or additions to documentation labels Jan 15, 2025
@Pfeil Pfeil added the good first issue Good for newcomers label Jan 23, 2025
@Pfeil Pfeil modified the milestones: 2.2.0, 2.2.1 Jan 26, 2025
@Pfeil
Copy link
Member Author

Pfeil commented Jan 28, 2025

Note: I do it exactly as described here, and it still doesn't work. I also tried a few things (making an explicit bean out of it, etc).

It also seems it is correctly recognized at runtime and used in the right order, but I didn't get to the point where it should be called (but isn't) so far:

Image

@Pfeil Pfeil linked a pull request Jan 28, 2025 that will close this issue
@Pfeil Pfeil linked a pull request Jan 28, 2025 that will close this issue
@Pfeil Pfeil changed the title ExtendedErrorAttributes does not seem to be registered ExtendedErrorAttributes are not invoked anymore Jan 28, 2025
@Pfeil Pfeil removed documentation Improvements or additions to documentation good first issue Good for newcomers labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant