Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation 'How to start' is misleading #186

Open
VolkerHartmann opened this issue Dec 13, 2023 · 4 comments
Open

Documentation 'How to start' is misleading #186

VolkerHartmann opened this issue Dec 13, 2023 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@VolkerHartmann
Copy link
Contributor

Describe the bug
I followed the 'How to start' instructions and unfortunately it didn't work.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout repo
  2. Execute './gradlew build'
  3. Copy config/application.properties to project folder ('cp config/application.properties .')
  4. Start service ('./builds/libs/TypedPIDMaker-2.1.0.jar')

Expected behavior
The documentation should be correct. ;-)
The file 'application.properties' has to be placed in the same folder as
the jar file or in a subdirectory of this folder called 'config'.
Otherwise the properties file will not be found.

ℹ️ Note:
As './gradlew clean build' will delete your settings its not recommended
to copy the config file into builds/libs directory!

ℹ️ Note:
Typo: The file 'conf/application.properties' doesn't exist.

ℹ️ Note:
It's not recommended to commit application.properties. It should be renamed (e.g.: application-default.properties') to avoid accidentally submitting credentials to Github.

ℹ️ Note:
And last but not least the documentation should be also fixed at https://kit-data-manager.github.io/webpage/typed-pid-maker/installation.html

@VolkerHartmann VolkerHartmann added the documentation Improvements or additions to documentation label Dec 13, 2023
@VolkerHartmann VolkerHartmann added this to the 2.2.0 milestone Dec 13, 2023
@Pfeil
Copy link
Member

Pfeil commented Jul 31, 2024

Related: We should give a short summary on how to run/skip the tests explicitly.

@Pfeil
Copy link
Member

Pfeil commented Oct 18, 2024

It should be renamed (e.g.: application-default.properties') to avoid accidentally submitting credentials to Github.

I looked in the Metastore repo to understand how you think I should set it up. But there, it is still perfectly possible to accidentally commit it in a profile-based properties file. I see how this is more convenient and standard, but I do not see how this does protect anyone from committing credentials.

It probably would be the safest to gitignore all *.properties files, and exclude the included files, but this will still leave a gap. Can you elaborate on that?

@VolkerHartmann
Copy link
Contributor Author

It's true, that it doesn't prevent you from commiting credentials, but why should you change default values to real credentials as you never use these config files for setting up your local test service as it is. At least you have to rename it.
Setting up a config file from scratch is a great effort.
Your .gitignore already ignores application.properties but this doesn't work in posteriori as you commited it before.
You can have a look at your comment in .gitignore for handling instructions. ;-)

@Pfeil
Copy link
Member

Pfeil commented Oct 21, 2024

Ok. I will fix this issue in two steps. I pulled in the docker thing because it is somehow related to the getting started story and will also require some additional documentation.

  • improve documentation in repo and overall "getting started experience", see Improve getting started experience #230
  • As soon as the docker story (to improve the getting started story) has been tested properly, (update: first tests have happened)
    • I will update the webpage
    • and make a proper documentation in this repo.

@Pfeil Pfeil modified the milestones: 2.2.0, 2.2.1 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants