Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Minor syntax highlighting issue #33

Open
adamierymenko opened this issue Aug 23, 2022 · 5 comments
Open

[BUG] Minor syntax highlighting issue #33

adamierymenko opened this issue Aug 23, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@adamierymenko
Copy link

adamierymenko commented Aug 23, 2022

Describe the bug
There's a minor syntax highlighting issue with the use of function generic parameters like Fn() and FnOnce().

To Reproduce
See attached screenshot for an example. Note that the highlighter reverts to white and basically stops highlighting until something resets it inside the function.

Expected behavior
Correct syntax highlighting.

Screenshots
Screen Shot 2022-08-23 at 6 14 57 PM

Versions (please complete the following information):

  • macOS Big Sur
  • Processor: Apple Silicon
  • Nova 9.5
@adamierymenko adamierymenko added the bug Something isn't working label Aug 23, 2022
@adamierymenko
Copy link
Author

Saw this again. Seems like function types have their -> misinterpreted as a template parameter or something.

@adamierymenko
Copy link
Author

BTW -- if you make this project sponsorable I'll throw you a sponsorship. I use this daily.

@kilbd
Copy link
Owner

kilbd commented Oct 20, 2022

Thanks for the vote of confidence – it really means a lot!

I apologize for not responding to this issue sooner, but I had a busy summer and now Nova 10 is coming in hot with Tree Sitter as its parsing engine. The good news is that many folks better than me at this sort of thing have written a Tree Sitter grammar so glaring issues like this should be rarer. I'm currently working on connecting the Tree Sitter syntax tree to Nova theme selectors and symbols. Nova 10 will likely show up before I'm ready, but I hope to follow its release shortly.

@adamierymenko
Copy link
Author

Ahh nice. Sounds like it'll make your job easier since you'll just have to worry about the rust language server stuff.

Your plugin still works better than Rust for VSCode which is crash city when using rust-analyzer and leaves zombie Rust language parser processes running that have to be manually killed (at least on macOS/ARM64).

kilbd added a commit that referenced this issue Mar 17, 2023
Adds necessary files for generating a parsing library and providing queries for Nova to use for syntax highlighting, symbols, etc.

Issues: #35, #33, #32
@kilbd
Copy link
Owner

kilbd commented Mar 17, 2023

Please let me know if this is still an issue in the latest version (if you're still using this extension). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants