Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML typings to all components, and make sure ...props are passed down to the correct element #88

Open
julrich opened this issue Nov 10, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@julrich
Copy link
Member

julrich commented Nov 10, 2023

Like here: 8b55c94

The ...props should be added as an argument, as well as spread into the correct tag of the component. The type to add depends on the tag the ...props end up on (e.g. <div {...props}>..</div> -> HTMLDivElement, <button {...props}/> -> HTMLButtonElement)

Especially:

@julrich julrich added the enhancement New feature or request label Nov 10, 2023
@fleven-kds fleven-kds transferred this issue from kickstartDS/ds-agency Nov 27, 2024
@julrich julrich transferred this issue from kickstartDS/ds-agency-premium Dec 5, 2024
@julrich julrich moved this to Ready in CMS Starter Storyblok Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready
Development

No branches or pull requests

2 participants