Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button border radius can't be changed through token #87

Open
fleven-kds opened this issue Nov 30, 2023 · 1 comment
Open

Button border radius can't be changed through token #87

fleven-kds opened this issue Nov 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@fleven-kds
Copy link
Collaborator

The button component utilizes the --c-button-border-radius token, which is initially set to --ks-border-radius-control. In the DSA theme, the button is designed to have a pill shape. However, not all control items should adopt this pill shape, so the component token is specifically overridden to --ks-border-radius-pill.

The issue here is that once the component token is overridden, it loses its connection to the original design token. As a result, it can no longer be modified through theming. This means that any changes made to the design token will not reflect on the button component because the link between them has been severed by the override.

@fleven-kds fleven-kds added the enhancement New feature or request label Nov 30, 2023
@fleven-kds fleven-kds transferred this issue from kickstartDS/ds-agency Nov 27, 2024
@julrich julrich changed the title Button border radius is not editable by token Button border radius can't be changed through token Dec 5, 2024
@julrich julrich transferred this issue from kickstartDS/ds-agency-premium Dec 5, 2024
@julrich julrich moved this to Backlog in CMS Starter Storyblok Dec 5, 2024
@julrich
Copy link
Member

julrich commented Dec 9, 2024

We should add --ks-border-radius-button to specifically control button radii here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants