Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TeaserCard: onclick function is conditional to button label #83

Open
fleven-kds opened this issue Jan 23, 2024 · 3 comments
Open

TeaserCard: onclick function is conditional to button label #83

fleven-kds opened this issue Jan 23, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@fleven-kds
Copy link
Collaborator

Currently the hover and onclick functions only work when a button label is set. However, the entire button is optional. This behavior should be modified so that the hover and onclick functions are conditional on a target being set, not on a button.label.
@fleven-kds fleven-kds added bug Something isn't working enhancement New feature or request labels Jan 23, 2024
@fleven-kds
Copy link
Collaborator Author

The fix needs to be applied in both the ds-agency and ds-agency-premium repos

@fleven-kds fleven-kds mentioned this issue Nov 27, 2024
Open
@fleven-kds
Copy link
Collaborator Author

A similar issue has been discovered here:
kickstartDS/ruhmesmeile#12

@fleven-kds fleven-kds transferred this issue from kickstartDS/ds-agency Nov 27, 2024
@julrich julrich transferred this issue from kickstartDS/ds-agency-premium Dec 5, 2024
@julrich julrich removed the enhancement New feature or request label Dec 5, 2024
@julrich julrich moved this to Ready in CMS Starter Storyblok Dec 5, 2024
@julrich
Copy link
Member

julrich commented Dec 9, 2024

Reminder: add ticket in ksDS for the base component: https://6080932e6ca776002127f0c5-xdxjumjsce.chromatic.com/?path=/docs/base-teaser-box--docs

Should fix this, when the upstream fix is there.

@julrich julrich moved this from Ready to Backlog in CMS Starter Storyblok Dec 9, 2024
@julrich julrich moved this from Backlog to Ready in CMS Starter Storyblok Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CMS Starter Storyblok
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julrich @fleven-kds