Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CurrentReplicas as a minimum for fallback replicas #6450

Open
rickbrouwer opened this issue Dec 31, 2024 · 0 comments · May be fixed by #6464
Open

Use CurrentReplicas as a minimum for fallback replicas #6450

rickbrouwer opened this issue Dec 31, 2024 · 0 comments · May be fixed by #6464
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@rickbrouwer
Copy link
Contributor

rickbrouwer commented Dec 31, 2024

Proposal

From the next discussion #6334 (Editing ScaledObject on Workload in Production).

My proposal is to add a new (boolean) parameter at the fallback: useCurrentReplicasAsMinimum
If this parameter is set to true and it ends up in a fallback, at least the number of replicas that are running at that moment will continue to run. If the fallback.replicas is higher, this setting will be used.

Use-Case

When you are running a large number of pods and something goes wrong, Keda uses a fallback (if configured). However, the difference between the fallback.replicas and the current number of replicas can be large.

Something going wrong can also be temporary, which means it can suddenly scale down considerably and then return to the correct number of replicas. With this feature we ensure that this does not happen.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

If you have any objections or questions regarding this issue, please let me know :)

@rickbrouwer rickbrouwer added feature-request All issues for new features that have not been committed to needs-discussion labels Dec 31, 2024
@rickbrouwer rickbrouwer linked a pull request Jan 5, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Status: To Triage
Development

Successfully merging a pull request may close this issue.

1 participant