Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for KDL 2.0 #24

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Support for KDL 2.0 #24

wants to merge 37 commits into from

Conversation

larsgw
Copy link
Collaborator

@larsgw larsgw commented Jan 4, 2025 •
edited
Loading

Fix #9
Fix #16
Fix #23
Close #21

larsgw added 20 commits January 4, 2025 14:31
@larsgw
test: update tests submodule
8692567
@larsgw
fix(parser): add whitespace escapes to quoted strings
59ed754
@larsgw
fix(parser): add vertical tab (0x0B) as newline
fab0f3c
@larsgw
fix(parser): update escaped characters for quoted strings
3226239
@larsgw
fix(parser): un-reserve ",", "<", and ">" from identifier strings
8fea358
@larsgw
fix(parser): disallow some literal code points
2035981
@larsgw
fix(parser): remove raw string prefix
972c49c
@larsgw
fix(parser): fix escline behavior
6de575c
@larsgw
fix(parser): remove '#' as identifier character
4559c86
@larsgw
fix(parser): update boolean/null literals
2903356
@larsgw
fix(parser): allow bare identifier strings
b38231b
@larsgw
fix(parser): implement float keywords
9ce2805
@larsgw
fix(parser): disallow more numeric-like bare identifiers
fb4db0d
@larsgw
fix(parser): disallow banned identifier values
45839cc
@larsgw
fix(parser): disallow escaped unicode scalar values
9c7d629
@larsgw
fix(parser): disallow more literal code points
fb5ee41
@larsgw
fix(parser): only allow U+FEFF at start of file
64ef565
@larsgw
fix(parser): implement bare identifier strings
ba220cb
@larsgw
fix(parser): fix slashdash behavior
c6a4111
@larsgw
fix(parser): update optional whitespace limitations
97cf99c
@larsgw larsgw marked this pull request as draft January 4, 2025 22:24
@larsgw larsgw mentioned this pull request Jan 4, 2025
Open
@larsgw larsgw changed the title Draft: Support for KDL 2.0 Support for KDL 2.0 Jan 5, 2025
@larsgw larsgw marked this pull request as ready for review January 5, 2025 20:28
@larsgw larsgw requested review from zkat and removed request for zkat January 5, 2025 20:29
zkat
zkat reviewed Jan 5, 2025
View reviewed changes
.github/workflows/gh-pages.yml
@@ -4,24 +4,24 @@ on:
workflow_dispatch:
push:
tags:
- '*'
- '*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why we don't like yaml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBF I think it worked regardless, it just didn't match the rest of the file (nor my expectations)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@larsgw @zkat