Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of type objects in parsers, serializers, and iterators #68

Open
kasei opened this issue Feb 8, 2016 · 0 comments
Open

Fix use of type objects in parsers, serializers, and iterators #68

kasei opened this issue Feb 8, 2016 · 0 comments
Assignees
Labels

Comments

@kasei
Copy link
Owner

kasei commented Feb 8, 2016

Attean->acceptable_parsers(handles => 'Attean::API::TripleOrQuad') should include all triple parsers, but right now only includes n-quads. This is caused by brittle use of type objects and role strings to do the type checking of what parsers and iterators produce, and serializers consume.

item_type and handled_type shouldn't assume that the types are either role strings, or Type::Tiny::Role objects. Instead, look into having them all use Type::Tiny objects, including Type::Tiny::Union. Then update the code in acceptable_parsers to use Type::Tiny's API to check that $pclass->handled_type (triples) is a subset of the preferred type (triples and quads).

@kasei kasei added the medium label Feb 8, 2016
@kasei kasei assigned kasei and unassigned kasei Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant