GCC 6 error: macro "min" passed 3 arguments, but takes just 2

[hfs]

FYBA fails to compile with GCC 6:

make[2]: Entering directory '/home/user/Downloads/fyba/src/FYBA'
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../..  --pedantic -Wno-long-long -Wall -O2 -D_FILE_OFFSET_BITS=64 -DUNIX -DLINUX -fPIC -Wno-write-strings -I../GM -I../UT   -g -O2 -MT FYLU.lo -MD -MP -MF .deps/FYLU.Tpo -c -o FYLU.lo FYLU.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. --pedantic -Wno-long-long -Wall -O2 -D_FILE_OFFSET_BITS=64 -DUNIX -DLINUX -fPIC -Wno-write-strings -I../GM -I../UT -g -O2 -MT FYLU.lo -MD -MP -MF .deps/FYLU.Tpo -c FYLU.cpp  -fPIC -DPIC -o .libs/FYLU.o
In file included from /usr/include/c++/6/bits/char_traits.h:39:0,
                 from /usr/include/c++/6/string:40,
                 from /usr/include/c++/6/bits/locale_classes.h:40,
                 from /usr/include/c++/6/locale:39,
                 from FYLU.cpp:11:
/usr/include/c++/6/bits/stl_algobase.h:243:56: error: macro "min" passed 3 arguments, but takes just 2
     min(const _Tp& __a, const _Tp& __b, _Compare __comp)
                                                        ^
/usr/include/c++/6/bits/stl_algobase.h:265:56: error: macro "max" passed 3 arguments, but takes just 2
     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
                                                        ^
In file included from stdafx.h:12:0,
                 from FYLU.cpp:7:
/usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected unqualified-id before ‘const’
     min(const _Tp& __a, const _Tp& __b)
     ^
/usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected ‘)’ before ‘const’
/usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected ‘)’ before ‘const’
/usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected ‘)’ before ‘const’
/usr/include/c++/6/bits/stl_algobase.h:195:5: error: expected initializer before ‘const’
/usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected unqualified-id before ‘const’
     max(const _Tp& __a, const _Tp& __b)
     ^
/usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected ‘)’ before ‘const’
/usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected ‘)’ before ‘const’
/usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected ‘)’ before ‘const’
/usr/include/c++/6/bits/stl_algobase.h:219:5: error: expected initializer before ‘const’
In file included from /usr/include/c++/6/bits/char_traits.h:39:0,
                 from /usr/include/c++/6/string:40,
                 from /usr/include/c++/6/bits/locale_classes.h:40,
                 from /usr/include/c++/6/locale:39,
                 from FYLU.cpp:11:
/usr/include/c++/6/bits/stl_algobase.h:243:5: error: ‘std::min’ declared as an ‘inline’ variable
     min(const _Tp& __a, const _Tp& __b, _Compare __comp)
     ^~~
/usr/include/c++/6/bits/stl_algobase.h:246:7: error: expected primary-expression before ‘if’
       if (__comp(__b, __a))
       ^~
/usr/include/c++/6/bits/stl_algobase.h:246:7: error: expected ‘}’ before ‘if’
/usr/include/c++/6/bits/stl_algobase.h:246:7: error: expected ‘;’ before ‘if’
/usr/include/c++/6/bits/stl_algobase.h:248:7: error: expected unqualified-id before ‘return’
       return __a;
       ^~~~~~
/usr/include/c++/6/bits/stl_algobase.h:265:5: error: ‘max’ declared as an ‘inline’ variable
     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
     ^~~
/usr/include/c++/6/bits/stl_algobase.h:268:7: error: expected primary-expression before ‘if’
       if (__comp(__a, __b))
       ^~
/usr/include/c++/6/bits/stl_algobase.h:268:7: error: expected ‘}’ before ‘if’
/usr/include/c++/6/bits/stl_algobase.h:268:7: error: expected ‘;’ before ‘if’
/usr/include/c++/6/bits/stl_algobase.h:270:7: error: expected unqualified-id before ‘return’
       return __a;
       ^~~~~~
/usr/include/c++/6/bits/stl_algobase.h:271:5: error: expected declaration before ‘}’ token
     }
     ^
Makefile:472: recipe for target 'FYLU.lo' failed
make[2]: *** [FYLU.lo] Error 1
make[2]: Leaving directory '/home/user/Downloads/fyba/src/FYBA'
Makefile:457: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/user/Downloads/fyba'
Makefile:366: recipe for target 'all' failed
make: *** [all] Error 2

As a temporary fix you can move #include "stdafx.h" below the other includes in src/FYBA/FYLU.cpp.

My g++ and libstdc++-6-dev version is 6.3.0-12ubuntu2 on Ubuntu zesty.

[adamjstewart]

I ran into the same problem with GCC 6.1.0 on CentOS 6.9. Your temporary fix worked perfectly!

[sickel]

Tried compiling on rocky linux 9, gcc 11.4.1, The mentioned fix does not help, so I am not able to compile.

[Lecheps]

Late to the party.
The issue are the macros "min" and "max" that are defined in some of the source files are in conflict with the identically named functions in stl_algobase. This works fine with older versions of gcc (and therefore of stl_algobase), but at some point it causes the compilation to fail.

My solution was to rename the macros and change the calls to min and max accordingly. I renamed the macros (and the respective calls) to MIN and MAX. This can be done in Linux (probably in Windows?) by running the following in the fyba base dir:

code
#We rename the macros to avoid name collisions. This is a blunt tool but it seems to work.
grep -rl 'max(' . | xargs sed -i "s/max(/MAX(/g"
grep -rl 'min(' . | xargs sed -i "s/min(/MIN(/g"
#In addition in FYLO.cpp there are two instances of the macro calls that were not captured (space between 'min' and '(' )
RUN grep -rl 'max (' . | xargs sed -i "s/max (/MAX(/g"
RUN grep -rl 'min (' . | xargs sed -i "s/min (/MIN(/g"
code

After that, it compiles with the latest gcc (there might be some assignement to NULL that is not supported, but in that case I initialized to 0 instead).

[sickel]

Throws a bunch of warnings but compiles fine here (Debian 12.8, gcc 12.2)
Would you mind making a pull request with the updated code?