-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 6 #14
Comments
Hi Samuel! Very nice meeting you in Edinburgh this summer, and great hearing from you. Apart from SpikeForest I know of no other initiative. Kampff lab has 2 datasets used on SpikeForest (https://spikeforest.flatironinstitute.org/studyresults/paired_kampff), the recordings that start with ‘c’ (‘c14’, ‘c16’ etc) are from my dataset (the one referred to in sc.io). Let me know if you have any questions and many thanks for your interest!
andre
…On 10 Sep 2019, 10:00 +0100, Garcia Samuel ***@***.***>, wrote:
Hi Andre,
we met in Edimburgh meeting in June.
I plan this autum (if I have time) to make a sorter comparison (your project 6) with our spikeinterface package.
Are you aware of any initiative on this task ?
Cheers,
Samuel Garcia
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thank for your answer. |
Hi Andre. Another quick question to be sure:
|
I wrote this small peak detection for the patch signal. I believe it is a bit more clearner. def detect_peak_on_patch_sig(patch_sig, sample_rate):
# filter because some traces have drift
sos = scipy.signal.iirfilter(5, 200./sample_rate*2, analog=False, btype = 'highpass', ftype = 'butter', output = 'sos')
patch_sig_f = scipy.signal.sosfiltfilt(sos, patch_sig, axis=0)
med = np.median(patch_sig_f)
mad = np.median(np.abs(patch_sig_f-med))*1.4826
thresh = med - 12 * mad
# 1 ms aounrd peak
d = int(sample_rate * 0.001)
spike_indexes, prop = scipy.signal.find_peaks(-patch_sig_f, height=-thresh, distance=d)
#~ fig, ax = plt.subplots()
#~ ax.plot(patch_sig_f)
#~ ax.axhline(thresh)
#~ ax.plot(spike_indexes, patch_sig_f[spike_indexes], ls='None', marker='o')
#~ plt.show()
return spike_indexes I can compare the indexe you give in the repo vs ones freshly dected by this functions:
As you can see, the differences is marginal except for c14 and c26 where there is a 2% of diference. In spikeforest, this 2% diferences can be moe than the accuracy differences between some sorters. I think it should be corrected. |
Hi Samuel, many thanks for your input and for defining the new function. I have updated the readme to add the neuropixel sampling rate and clarify the patch rate was 50.023 kHz. I have also clarified an issue which may have gone under the radar. If you look at the data summary (https://github.com/kampff-lab/sc.io/blob/master/Paired%20Recordings/Preprint%20Code/Data%20Summary.xlsx), particularly the last column on that spreadsheet, you can see there was a very small variation in sampling rate from cell to cell. For that reason the conversion factor between the two signals is specific for each patch clamp recording. I wonder if this was the reason for the discrepancy in the cells you mentioned. |
Thanks again Samuel - just adding a note that I took down the npy arrays detailing extracellular spike times to be safe. I added a readme in their folder linking to your post here with the function, to prevent people running into the issue of inaccurate spike times in the cells you mentioned. |
Hi Andre,
we met in Edimburgh meeting in June.
I plan this autum (if I have time) to make a sorter comparison (your project 6) with our spikeinterface package.
Are you aware of any initiative on this task ?
Cheers,
Samuel Garcia
The text was updated successfully, but these errors were encountered: