Suggestion to add further controls

[confuzius0815]

Hi,

According to my findings, some of the Heishamon topics below are currently not available via HA (maybe because they are not documented in Heishamon MQTT topics but only in OptionalPCB.md).

const optCmdStruct optionalCommands[] PROGMEM = {
  // optional PCB
  { "SetHeatCoolMode", set_heat_cool_mode },
  { "SetCompressorState", set_compressor_state },
  { "SetSmartGridMode", set_smart_grid_mode },
  { "SetExternalThermostat1State", set_external_thermostat_1_state },
  { "SetExternalThermostat2State", set_external_thermostat_2_state },
  { "SetDemandControl", set_demand_control },
  { "SetPoolTemp", set_pool_temp },
  { "SetBufferTemp", set_buffer_temp },
  { "SetZ1RoomTemp", set_z1_room_temp },
  { "SetZ1WaterTemp", set_z1_water_temp },
  { "SetZ2RoomTemp", set_z2_room_temp },
  { "SetZ2WaterTemp", set_z2_water_temp },
  { "SetSolarTemp", set_solar_temp },
  { "SetOptPCBByte9", set_byte_9 }
};

IMHO at least "SetCompressorState" (values are 0 and 1) would be interresting... depending on the position of Pin 3 of SW 2 on the Main PCB it switches the Compressor (Pin 3 off) or the booster/backup heater(s) (Pin 3 on).
This is a write-only value of the optional PCB emulation and is effective only if "External Compressor Control" is ON. Testet it with a MQTT switch and it works for compressor off with Pin 3=off while it does not shut down the comrpessor with Pin 3=on (currently, I have no active backup/booster heater so this is not tested).

My suggestion would be renaming the "External Compressor Control" switch to "External Compressor Control Enabled" and adding "External Compressor Control Switch" (or something like that - at least something that indicates the connection between the two switches).

Similar but much less relevant topic for most use cases would be "SetHeatCoolMode" vs. "External Heat Cool Control" (enabled switch) which anyways works only if cooling is configured.

Unfortunately, my understanding of your code (and my coding abilities) are not good enough to create a fully elaborated pull request. I just assume that adding something in definitions.py (e.g. in the block defining External Compressor Control) would do the job.
Best regards

[geduxas]

yes it's for optional pcb emulation, to manipulate original board working logic. no use for those who have optional PCB installed.. so it should be somehow filtered...

also some features from K/L series have moved from optional PCB to main PCB, so not possible emulate also..

[confuzius0815]

Thank you very much for your remark. Indeed, this will be relevant only for those who have the "optional PCB emulation" active. The same is true for SetDemandControl, which is not filtered (according to my understanding). So I think, it needs not be filtered (it will simply have no effect when optional PCB emulation is disabled).

Regarding at least the L series, I can confirm that SetCompressorState works as expected when SetExternalCompressorControl is enabled (i.e. the function is still on the optional PCB and presumably works as in the J series).

[geduxas]

J and H series share's same expansion board, and feom K series it's changed.. so some functions moved to main pcb.. don't remember right now what, but if remember correctly it's related to buffer tank and zone 1..