You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi there, I just took a look, I think this is a great start. At the moment, you are explaining in great detail the filter command options, what I am looking for in this section, in addition, is how it is implemented in the source code -- just as an overview where people would be able to find it. I guess we can add more detail in the future. It might be worth asking in the main K8sGPT repo or on Slack for some of the other contributors to get involved. We could merge this PR for now and create a new issue based on my feedback to address that. What do you think?
Hi there, I just took a look, I think this is a great start. At the moment, you are explaining in great detail the filter command options, what I am looking for in this section, in addition, is how it is implemented in the source code -- just as an overview where people would be able to find it. I guess we can add more detail in the future. It might be worth asking in the main K8sGPT repo or on Slack for some of the other contributors to get involved. We could merge this PR for now and create a new issue based on my feedback to address that. What do you think?
Oh, so are you suggesting adding information on where the filter command is implemented or a certain part is implemented in the codebase?
Oh, so are you suggesting adding information on where the filter command is implemented or a certain part is implemented in the codebase?
Yes, explaining the codebase in the explanation section vs. using the CLI is in the reference section
Oh, so are you suggesting adding information on where the filter command is implemented or a certain part is implemented in the codebase?
Yes, explaining the codebase in the explanation section vs. using the CLI is in the reference section
Great idea, I can do it in this PR or we can raise another issue for it too, as you say.
Actually, me and Anais discussed adding more information about how to navigate through the codebase for filters above, but we just merged #69 in which we provide an explanation for integrations, now have we moved on from this idea as I don't really see this idea being implemented in that PR?
If not, then I can add this additional information in separate PRs for both.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnaisUrlichs
changed the title
Closes #48
📑 Description
Changes made-
filtersunder explanation.index.mdfile under explanation.reference/cli/filters.md✅ Checks