Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JupyterLab 2.1 #30

Closed
fzimmermann89 opened this issue Apr 23, 2020 · 7 comments
Closed

Support for JupyterLab 2.1 #30

fzimmermann89 opened this issue Apr 23, 2020 · 7 comments

Comments

@fzimmermann89
Copy link

fzimmermann89 commented Apr 23, 2020

Hi,

are there any plans to publish an update that's compatible with JLab >=2.0 ?

Thanks :)

@pablooriol2
Copy link

I second this. Just installed Jupyterlab and got the following error

Screenshot 2020-05-01 at 12 48 36

I reinstalled Jupyterlab with version 2.0 but still get the same error message. Quite inconvenient as I was very much looking forward to using the viewer in jupyterlab! There aren't that many HDF viewers out there..

@snmhas
Copy link

snmhas commented May 18, 2020

I am also looking forward to have this extension with the latest version of Jupyterlab. Is there any progress?

@nitrocalcite
Copy link

I attempted to simply hack config.json and rename lumino, but with no luck. As a longtime notebook user but new lab user, I did not expect to find that this apparently official extension is currently bricked. I was also rather disappointed that both the current state and future of this extension is unclear.

@athornton
Copy link
Member

Adding my voice here: I too would like to have an HDF5 viewer in current and future JupyterLabs.

@cnydw
Copy link
Member

cnydw commented Jul 31, 2020

I tried to update my local clone to make it work with JL 2.1+, and found out except for updating @phosphor libraries with @lumino, the dependencies

"@jupyterlab/dataregistry": "^3.0.0",
"@jupyterlab/dataregistry-extension": "^3.0.0",

don't support JL 2.1+ yet, which was brought up in jupyterlab/jupyterlab-data-explorer#138

I installed the master branch of jupyterlab-data-explorer (which supports JL 2.1) and tried to install jupyterlab-hdf5 using NPM local dependencies

"@jupyterlab/dataregistry": "file:../jupyterlab-data-explorer/packages/dataregistry",
"@jupyterlab/dataregistry-extension": "file:../jupyterlab-data-explorer/packages/dataregistry-extension"

But I encountered the error

npm ERR! code ENOENT
npm ERR! syscall access
npm ERR! path /github/jupyterlab-data-explorer/packages/dataregistry-extension/node_modules/@types/react
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, access '/github/jupyterlab-data-explorer/packages/dataregistry-extension/node_modules/@types/react'

Seems it relates to the jupyterlab-data-explorer packaging structure (node_modules in the root folder, then the individual packages in /packages)

Any suggestions on how to proceed with my local installation? I would love to help update the hdf5 extension to support JL 2.1+.

@loichuder
Copy link
Collaborator

loichuder commented Aug 11, 2020

@cnydw, did you build the jupyterlab-data-explorer using jlpm build ?

Because, following your tries, I managed to build the extension on JupyterLab 2.1 by installing the jupyterlab-data-explorer extensions from the master branch, updating all @jupyterlab dependencies in package.json and replacing @phosphor by @lumino.

I also had to fix some IRegistry imports.

The resulting extension (https://github.com/loichuder/jupyterlab-hdf5/tree/jupyter2.1) is then available in my JupyterLab instance but I get the Directory not found error described in #29 when clicking on hdf5 files.

I tried on JupyterLab 2.2 and this time, I do not get the Directory not found error but I am unable to explore any data. I get blank pages instead of data grids (see below) and I get DOMException: An attempt was made to use an object that is not, or is no longer, usable in the browser console.
image

@telamonian
Copy link
Member

The latest v0.4.0 release now includes support for juptyerlab 2.x (tested with the latest jlab v2.2.7 release).

@fzimmermann89 @pablooriol2 @snmhas @nitrocalcite @athornton @cnydw @loichuder Please try out the standard jupyterlab-hdf install:

pip install jupyterlab_hdf
jupyter labextension install @jupyterlab/hdf5

and let me know if you run into any further troubles in a fresh issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants