How to correctly use WidgetLSPAdapter to enable code completion in the code editor of custom extension

[boogie-ben]

I have written a custom extension which supports files with the .cpw suffix. After opening a .cpw file, there will be 0 to N code editors (created by newInlineEditor of the CodeMirrorEditorFactory instance).

I expect to get the code completion feature in these code editors.

I wrote a CPWAdapter by imitating NotebookAdapter and FileEditorAdapter. It can successfully start the LSP connection and communicate for .cpw files, but I haven't found the correct implementation to enable the code completion feature for the code editors. I'm asking for help.

I have created a minimum reproducible code repository. Please evaluate my code and let me know if there are any problems with my implementation process.

minimum reproducible

Current progress:

1. In the activate function in index.ts, I use WidgetTracker and new CPWAdapter in widgetAdded.
2. In CPWWidget, code editors are created in the content area. (In the actual business process, code editors are generated dynamically and there may be 0 or more of them.)
3. After a certain code editor gets focused, it is designated as the activeEditor.
4. In CPWAdapter, when the activeEditor is switched or its content changes, the VirtualDocument is updated.

[boogie-ben]

3demo.mp4

This is the current effect. I expect the code completion of each code editor to be independent. Therefore, the content of the VirtualDocument should only contain the content of the activeEditor, rather than the content of all the code editors.

[krassowski]

You will need to register a custom completion provider which sends textDocument/completion requests. This happens in:

jupyterlab-lsp/packages/jupyterlab-lsp/src/features/completion/index.ts

Line 102 in ec483e9

export const COMPLETION_PLUGIN: JupyterFrontEndPlugin<ICompletionFeature | null> =

And the provider is implemented in:

jupyterlab-lsp/packages/jupyterlab-lsp/src/features/completion/provider.ts

Line 42 in ec483e9

export class CompletionProvider implements ICompletionProvider<CompletionItem> {

I imagine that you could inherit from the provider class of jupyterlab-lsp.

[boogie-ben]

@krassowski
Thank you for your reminder. I have used the CompletionProvider and imitated the code of notebook-extension

my code

Now the code completion has taken effect!

However, I found that some features are still missing in my editor instance, such as the hover feature, the highlighting of error, and so on. That is to say, the HoverFeature and other features in the LSP are not working in my editor instance. What should I do next?