From 89323b517976d8c61987b3e8b9643bdf86e7450e Mon Sep 17 00:00:00 2001 From: Kristoffer Dalby Date: Fri, 31 Jan 2025 12:36:35 +0100 Subject: [PATCH] set minimum hostname length of 2 Signed-off-by: Kristoffer Dalby --- CHANGELOG.md | 2 ++ hscontrol/util/dns.go | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c71f5ad5ad..20777beb57 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ [#2391](https://github.com/juanfont/headscale/pull/2391) - Do not allow renaming of users from OIDC [#2393](https://github.com/juanfont/headscale/pull/2393) +- Change minimum hostname length to 2 + [#2393](https://github.com/juanfont/headscale/pull/2393) ## 0.24.2 (2025-01-30) diff --git a/hscontrol/util/dns.go b/hscontrol/util/dns.go index c87714d095..54a9452d92 100644 --- a/hscontrol/util/dns.go +++ b/hscontrol/util/dns.go @@ -65,6 +65,11 @@ func ValidateUsername(username string) error { } func CheckForFQDNRules(name string) error { + // Ensure the username meets the minimum length requirement + if len(name) < 2 { + return errors.New("name must be at least 2 characters long") + } + if len(name) > LabelHostnameLength { return fmt.Errorf( "DNS segment must not be over 63 chars. %v doesn't comply with this rule: %w",