Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(transloco): translation randomly not resolved for some clients #801

Open
1 task done
KessoumML opened this issue Sep 18, 2024 · 3 comments
Open
1 task done

Comments

@KessoumML
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Which Transloco package(s) are the source of the bug?

Transloco

Is this a regression?

No

Current behavior

We have an issue that happens randomly and couldn't reproduce related to resolving variables in translation:

  • translation json key/value: "Créer un record": "Créer un{{e}} {{title}}",
  • translation call: {{ translate("Créer un record", {e: 'foo', title: 'bar', n : 'baz'}) }}
  • I think it's not browser cache related but it may be a cache issue because it solved if the page is refreshed with ctrl+f5

image

image

Sorry that I cannot provide a link for the bug, it's not possible to reproduce

Expected behavior

image

Please provide a link to a minimal reproduction of the bug, if you won't provide a link the issue won't be handled.

https://codesandbox.io/s/ngneat-transloco-kn52hs

Transloco Config

module.exports = {
  rootTranslationsPath: 'src/assets/i18n/',
  langs: ['en', 'fr', 'cn'],
  keysManager: {}
};

Please provide the environment you discovered this bug in

Transloco: 7.4.0
Angular: 17
Node: 19
Package Manager: npm
OS: Windows

Browser

Chrome desktop all versions

Additional context

hkukhjk

I would like to make a pull request for this bug

Yes 🚀

@shaharkazaz
Copy link
Collaborator

@KessoumML doing a regular refresh resolves the issue as well?
Without reproduction, there is not much I can do here.

@KessoumML
Copy link
Author

No, regular refresh doesn't fix the issue. it should be ctrl + f5.
The cache configuration is set to no cache
image
I'm currently exploring the possibility of including release hash to translated files to see if it fixes the issue.
Truly, there is no much to do if I can't reproduce it

@mberthouzoz
Copy link

Hi,

I found this issue: #110

I don't know if it can help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants