Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build non-apt dependencies #233

Closed
furushchev opened this issue Apr 9, 2016 · 15 comments
Closed

build non-apt dependencies #233

furushchev opened this issue Apr 9, 2016 · 15 comments

Comments

@furushchev
Copy link
Member

In case that test packages are depend on some packages which is not released on apt, how we should append and build them on test?

@wkentaro
Copy link
Member

wkentaro commented Apr 9, 2016

What is test packages?

@furushchev
Copy link
Member Author

@wkentaro in jsk_roseus repository, they are roseus, roseus_smach, roseus_mongo and roseus_tutorials.
roseus_tutorials package depends on a not-yet-released-as-deb package.
I added it to .travis.rosinstall, but still it doesn't be built.
(In build process, build command is executed with --no-dep, so it is reasonable that dependencies are not built, but I'd like to build dependencies too.)

@furushchev
Copy link
Member Author

O, I misunderstood, it was executed without --no-dep. Anyway it is weird not to be built dependencies.

@furushchev
Copy link
Member Author

ok. if USE_DEB is not set false, no packages are downloaded.
I'm trying to add option ROSINSTALL_FILES to jsk_travis to install custom rosinstall files.
#235

@wkentaro
Copy link
Member

👍

@k-okada
Copy link
Member

k-okada commented Apr 10, 2016

sorry I can not understand why just adding to '.travis.rosinstall' does not work? did you add them into test_depend in package.xml ?

@furushchev
Copy link
Member Author

@k-okada Currently .travis.rosinstall in jsk-ros-pkg/jsk_roseus repo is used to test euslisp-release and jskeus-release with roseus. I think we cannot use .travis.rosinstall to fetch not-released packages as is done in other repos in this case.
The problem is .travis.rosinstall is merged to .rosinstall only when USE_DEB=false, not when USE_DEB=source

@wkentaro
Copy link
Member

USE_DEB=true

  • .travis.rosinstall: not used
  • .travis.rosinstall.$ROS_DISTRO: not used
  • setup-upstream.sh: not used
  • $ROS_INSTALL_FILES (default: ""): used

USE_DEB=false

  • .travis.rosinstall: used
  • .travis.rosinstall.$ROS_DISTRO: used
  • setup-upstream.sh: not used
  • $ROS_INSTALL_FILES (default: ".travis.rosinstall .travis.rosinstall.$ROS_DISTRO"): used

USE_DEB=source

  • .travis.rosinstall: not used
  • .travis.rosinstall.$ROS_DISTRO: not used
  • setup-upstream.sh: used
  • $ROS_INSTALL_FILES (default: ""): used

@k-okada
Copy link
Member

k-okada commented Apr 10, 2016

please ask for release

◉ Kei Okada

On Mon, Apr 11, 2016 at 1:31 AM, Furushchev [email protected]
wrote:

@k-okada https://github.com/k-okada Currently .travis.rosinstall in
jsk-ros-pkg/jsk_roseus repo is used to test euslisp-release and
jskeus-release with roseus. I think we cannot use .travis.rosinstall to
fetch not-released packages as is done in other repos in this case.
The problem is .travis.rosinstall is merged to .rosinstall only when
USE_DEB=false, not USE_DEB=source


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#233 (comment)

@furushchev
Copy link
Member Author

@k-okada
Copy link
Member

k-okada commented Apr 10, 2016

which program do you use in tabletop_object_perception ?

◉ Kei Okada

On Mon, Apr 11, 2016 at 1:49 AM, Furushchev [email protected] wrote:

opened issue
ros-interactive-manipulation/tabletop_object_perception#1


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@k-okada
Copy link
Member

k-okada commented Apr 10, 2016

if we can pass travis by ROS_INSTALL_FILES, I'm afraid we'll have

trouble on bloom-release in the future.

◉ Kei Okada

On Mon, Apr 11, 2016 at 1:51 AM, Kei Okada [email protected] wrote:

which program do you use in tabletop_object_perception ?

◉ Kei Okada

On Mon, Apr 11, 2016 at 1:49 AM, Furushchev [email protected] wrote:

opened issue
ros-interactive-manipulation/tabletop_object_perception#1


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@furushchev
Copy link
Member Author

@k-okada
Copy link
Member

k-okada commented Apr 10, 2016

I wonder if we can "easily" rewrite them with jsk_pcl_ros

◉ Kei Okada

On Mon, Apr 11, 2016 at 2:02 AM, Furushchev [email protected]
wrote:

there is tabletop demo launch in roseus_tutorials.

https://github.com/jsk-ros-pkg/jsk_roseus/blob/master/roseus_tutorials/launch/tabletop-object-detector.launch#L89


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#233 (comment)

@furushchev
Copy link
Member Author

ok, I rewrote relatively easily
jsk-ros-pkg/jsk_pr2eus#217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants