Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is README.md out of date regarding prettier installation? #93

Closed
aspiers opened this issue Sep 19, 2021 · 2 comments
Closed

Is README.md out of date regarding prettier installation? #93

aspiers opened this issue Sep 19, 2021 · 2 comments

Comments

@aspiers
Copy link

aspiers commented Sep 19, 2021

The README.md says:

The Prettier package needs to be installed inside your npm package, or globally with either npm or yarn. Version 1.6 is the minimum requirement but it's recommended to use the latest version in order to get access to all parsers, features and bugfixes.

However, the docstring for prettier--create-process says:

The process is launched by running node with a minified version of bootstrap.js as a script provided on the command line; this then loads a minified version of prettier-el.js from stdin.

I can certainly see the minified version being used in my case, and I can only see that version being launched in the source code too, which leads me to suspect that the README.md is out of date. Is that right?

Bearing in mind issues like the one I mentioned in #92 where I am getting different results between prettier.el and the prettier I've installed via yarn, it would actually be helpful to be able to choose which prettier executable to use.

@jscheid
Copy link
Owner

jscheid commented Sep 19, 2021

I don't think I follow, is it possible there is confusion between prettier-el.js -- a helper file that ships with this package -- on the one hand, and the prettier npm package on the other? As far as I can see the README is still correct -- if it isn't then it's the code that needs fixing, not the documentation.

@aspiers
Copy link
Author

aspiers commented Sep 19, 2021

@jscheid commented on September 20, 2021 12:01 AM:

I don't think I follow, is it possible there is confusion between prettier-el.js -- a helper file that ships with this package -- on the one hand, and the prettier npm package on the other?

Ah yes - sorry. And now I find this comment I wrote last year and start to feel worried that my memory is deteriorating with age...

@aspiers aspiers closed this as completed Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants