Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedIn feed eradication not working on Firefox #323

Open
ReticulatedSpline opened this issue Dec 9, 2024 · 11 comments
Open

LinkedIn feed eradication not working on Firefox #323

ReticulatedSpline opened this issue Dec 9, 2024 · 11 comments

Comments

@ReticulatedSpline
Copy link

There are some related existing issues (e.g. #183) but they're either old or slightly different scenarios. Currently, I'm not seeing eradication occur at all on LinkedIn. If I can carve out some time later I will dig into this deeper as I hate the LinkedIn feed with a passion 🙏

NFE 2.2.7
Firefox 130.0.1
Ubuntu 24.04.1 LTS

@reinvanimschoot
Copy link

I have the same issue
NFE 2.2.7
Firefox 133.0
MacOS Sequoia 15.1.1

@ReticulatedSpline ReticulatedSpline changed the title Eradicaiton not working on LinkedIn on Firefox Eradication not working on LinkedIn on Firefox Dec 11, 2024
@ReticulatedSpline
Copy link
Author

ReticulatedSpline commented Dec 11, 2024

There's not much in the LinkedIn specific typescript... I confirmed that the scaffold class still exists, at least...
const feed = document.querySelector('.scaffold-finite-scroll');

And if you manually apply the .css to the element it zaps it as expected:
linkedin.str.css

My guess is that the CSS selector is no longer working, but I'm a bit of a web noob so I can't say for sure.

@ReticulatedSpline ReticulatedSpline changed the title Eradication not working on LinkedIn on Firefox LinkedIn feed eradication not working on Firefox Dec 11, 2024
@sardination
Copy link

Interestingly enough, when I load this extension from file (either as a temporary extension on regular Firefox or as a packaged and unsigned extension on Firefox Developer Edition), it works on LinkedIn. When I use the version on the add-ons store, it doesn't work. I think the version available for download from the add-ons store is outdated.

@ReticulatedSpline
Copy link
Author

Nice catch. The last github release is 2.3.0 whereas the last published to Firefox is 2.2.7.

@ReticulatedSpline
Copy link
Author

ReticulatedSpline commented Dec 17, 2024

I see that manifest-chrome.json has been updated but not manifest.json which seems to be what Firefox reads. I tried to sync them up but I am unable to get it working locally. @sardination what's your process? For reference I'm zipping the /src/ directory and uploading at about:debugging#/runtime/this-firefox.

@sardination
Copy link

Sorry, forgot to include that! I use the contents of the current manifest-chrome.json but with the following changes:

--- a/src/manifest-chrome.json
+++ b/src/manifest-chrome.json
@@ -37,8 +37,7 @@
                "default_title": "News Feed Eradicator"
        },
        "background": {
-               "service_worker": "service-worker.js",
-               "type": "module"
+               "scripts": ["service-worker.js"]
        },
        "options_ui": {
                "page": "options.html",
@@ -51,5 +50,13 @@
                "48": "icon48.png",
                "64": "icon64.png",
                "128": "icon128.png"
+       },
+       "content_security_policy": {
+           "extension_pages": "script-src 'self' 'wasm-unsafe-eval'; object-src 'self';"
+         },
+         "browser_specific_settings": {
+               "gecko": {
+                       "id": "@news-feed-eradicator"
+               }
        }
 }

@ReticulatedSpline
Copy link
Author

After playing around for a bit I'm unable to get this working on my machine :(
However I think the fix is straightforward...

  1. PR to update manifest.json provided above
  2. Rebuild /dist
  3. Submit build to AMO

Steps 1 and 3 probably require author intervention.

@jordwest
Copy link
Owner

Thanks everyone for looking into this! Yeah I've been meaning to update Firefox to 2.3.0 but because the extensions was upgraded to manifest v3 and Firefox doesn't yet support all manifest v3 features, I had to split the manifest into separate files.

Unfortunately just changing the scripts to the reworked service-worker.js wasn't enough to appease Firefox, but maybe that content_security_policy is the ticket. I'll need to sit down and try a few things when I have some time hopefully over the holiday break.

@sardination
Copy link

@ReticulatedSpline if you want it to work right now before it's updated on the add-ons store, you have to do one of the following after updating the manifest:

  1. Install as a temporary extension by running make dev and then loading the unpacked build as a temporary extension. The issue with temporary extensions is that they won't stay installed between restarts.
  2. Install as a packaged and unsigned extension on Firefox Developer Edition. Do this by running make and loading the packaged .zip as an add-on. You'll have to disable add-on signing. Due to security policies, you can't do this on the normal distro of Firefox.

Hope that helps!

@Alexplores
Copy link

Hi all,

Hopefully you all have warm holidays.

I want to inform you that I am experiencing the same issue since somewhere mid-November.

I've already tried updating everything related + reinstalling NFE and removing cookies etc.

Firefox version: 133.0.3 (64-bit)
OS: Microsoft Windows 11 Home 10.0.26100 Build 26100

Great to see that there's already work done on this. Wishing you all the best in fixing the issue

Thank for your continued support in safeguarding my productivity!

~ A

@DreamweaverMarz
Copy link

Fwiw for others on this thread. I ran into this issue and temporarily installed this extension; hoping it works for others as at least a short-term solution

https://github.com/agliber/linkedin-feed-blocker/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants