Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port and add more tests #20

Open
jonhoo opened this issue Jan 24, 2020 · 7 comments
Open

Port and add more tests #20

jonhoo opened this issue Jan 24, 2020 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.0

Comments

@jonhoo
Copy link
Owner

jonhoo commented Jan 24, 2020 •
edited
Loading

There are many Java tests that we do not yet have in the Rust version. You can find most of them in this file from JSR166 and in this folder from JDK. Let's port all of them and get that test coverage up! I would particularly love to get some of the concurrent tests ported over!

There are also a good chunk of tests over in hashbrown that would be good to also run against flurry.
@jonhoo jonhoo added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 24, 2020
@jonhoo
Copy link
Owner Author

jonhoo commented Jan 24, 2020

There are even more hashbrown unit tests here.

@jonhoo
Copy link
Owner Author

jonhoo commented Jan 25, 2020 •
edited
Loading

The C++ concurrent hash table libcuckoo has its own set of tests over here that would be great to port! It also has some "stress tests".

@jonhoo
Copy link
Owner Author

jonhoo commented Jan 25, 2020

junction is another C++ concurrent hash table (several actually), and it has a number of tests (and simple benchmarks) here that we could probably use as inspiration.

@jonhoo jonhoo added this to the 1.0 milestone Jan 31, 2020
@Stupremee
Copy link
Contributor

Some of the java tests also serve as benchmarks. Should we port the benchmarks as well or just the tests?

@jonhoo
Copy link
Owner Author

jonhoo commented Feb 11, 2020

Probably both ultimately. Porting them into separate files seems like a good idea. And the benchmark-like tests should be written using criterion so we can run regression tests on them.

@Stupremee
Copy link
Contributor

I would like to implement some tests and some benchmarks. Especially a stress test like libcuckoo

@GarkGarcia GarkGarcia mentioned this issue Mar 27, 2020
Merged
@jonhoo
Copy link
Owner Author

jonhoo commented Mar 27, 2020

As a follow-up to #78, we should also add tests for HashSetRef!

@jonhoo jonhoo mentioned this issue Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@jonhoo @Stupremee