Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Refactor bias handling #963

Open
4 tasks
asoplata opened this issue Jan 10, 2025 · 1 comment
Open
4 tasks

REF: Refactor bias handling #963

asoplata opened this issue Jan 10, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers maint Maintenance refactor
Milestone

Comments

@asoplata
Copy link
Collaborator

Re-organize External Bias handling to resemble how External Drives are handled:

  • Distinguish between type and name for biases (similar to drives)
    • (This should allow for better organization of multiple biases of the same type but different names in params usage)
  • Separate bias code from drive code (such as in drives.py:_add_drives_from_params())
  • Update config file format to reflect these changes, including both separation of type and name
  • Un-hardcode any current code that only uses tonic (such as params.py::_extract_bias_specs_from_hnn_params())
  • What else?
@jasmainak
Copy link
Collaborator

Don't think any "refactor" issue is a "good first issue" ;-) Do keep in mind that if you change the internals in a way that it may break user code, you would have to deprecate ... if it's just moving private functions around, then there is no need to worry of course.

particularly if you want the code to be adopted outside Jones lab; it is sometimes better to keep sub-optimal code if it doesn't break old user code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers maint Maintenance refactor
Projects
None yet
Development

No branches or pull requests

2 participants