Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need a better error for corruption in the password DB #37

Open
therealbstern opened this issue Feb 16, 2018 · 1 comment
Open

We need a better error for corruption in the password DB #37

therealbstern opened this issue Feb 16, 2018 · 1 comment
Labels
question ❓

Comments

@therealbstern
Copy link
Collaborator

We need a better error for corruption in the password DB
@therealbstern
Copy link
Collaborator Author

AFAICT, the only times corruption is identified is when either FileBackingStore::line_has_user or FileBackingStore::hash_is_locked discover that a line is missing a password. (v0.8.0 has another case, which I added in 0.8.0 and took back out in a71ae76 because it's not very important.)

At that point, both of them return BackingStoreError::MissingData, which is correct. We could rename it to DataCorruption if you like, but otherwise, I think we're set.

If either of them find a bad line, the rest of the database is suspect anyway, so barfing is the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question ❓
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@therealbstern