-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support session variables #3
Comments
This is a little out of scope; session variables are probably better handled by the owner. |
One thing that is currently a little awkward is support for anonymous sessions. Would a connection struct that contained a |
Hmm. I suppose it's possible to tell them apart, but it wasn't what I was expecting. This is probably worth doing, though. |
The user isn't logged on. They just connected, and we issued them a `sessionId`, and we'll remember and expire it like any `sessionId`, but they are anonymous. Anonymous sessions could have data associated with them, but when the session expires, that data is essentially lost.
|
... We don't track the username right now. What you really want is a policy that allows anonymous logins. Right now, our naive policy allows this. I think this is application-level. |
We track the user that is associated with a What I am thinking of is something to replace the enum ConnectionType {
Anonymous(ConnectionSignature),
LoggedIn(ConnectionSignature, String),
} We include the ConnectionString in the logged in case so the application can migrate information after the user logs in (or more likely, creates an account). This can all be done on the application side now, but is a bit messy, and seems a common use case. |
Hmm, this seems pretty reasonable. Do you want to grab it or should I do it? |
I think it's a different issue, though. This issue is really for session variables. |
Right now, this module only supports authentication. Once that's out of the way, we can start looking at session variables (which might cause more lifetime problems).
The text was updated successfully, but these errors were encountered: