Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to turn off logging in testing #1214

Open
1 task done
vladkrasn opened this issue Jan 17, 2025 · 0 comments
Open
1 task done

Add an option to turn off logging in testing #1214

vladkrasn opened this issue Jan 17, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@vladkrasn
Copy link

vladkrasn commented Jan 17, 2025

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

I see that here logger is explicitly turned off.

export interface CommanderOptionsType
  extends Omit<CommandFactoryRunOptions, 'logger'> {
  pluginsAvailable?: boolean;
}

Though it would be really nice if, at least in testing, we could set logger: false so that unneeded lines won't spawn

Describe the solution you'd like

If logger variable was hidden for a reason, maybe there's an option to pass false to it still? Or come up with another variable?

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

Would be nice to write tests with expected errors that don't clog the console

@vladkrasn vladkrasn added the enhancement New feature or request label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant